Re: [edk2-test PATCH v1 0/2] Add RISCV64 support to SctPkg

["Heinrich Schuchardt" <xypron.glpk@gmx.de>]

On 08.02.21 15:30, Daniel Schaefer wrote:
> On 12/2/20 1:37 AM, Heinrich Schuchardt wrote:
>> On 12/1/20 6:11 PM, Daniel Schaefer wrote:
>>> On 12/2/20 12:59 AM, Heinrich Schuchardt wrote:
>>>> On 12/1/20 5:17 PM, Daniel Schaefer wrote:
>>>>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042
>>>>>
>>>>> With this patch series we can build the UEFI SCT for RISCV64. It was
>>>>> confirmed
>>>>> to be working on the U-Boot UEFI implementation by Heinrich.
>>>>> It hasn't been tested on EDK2 yet.
>>>>>
>>>>> Build requirements are the same as for the EDK2 RISCV64 port and
>>>>> detailed here:
>>>>> https://github.com/riscv/riscv-uefi-edk2-docs
>>>>>
>>>>> The second patch is a big one because it adds architecture specific
>>>>> files by
>>>>> copying them from the Aarch64 directory. Only a single file, an
>>>>> assembly file
>>>>> needed modifications. I'm not sure why the other ones are in an
>>>>> architecture
>>>>> specific directory. They're all C files and seem to be generic. We
>>>>> can probably
>>>>> unify them.
>>>>
>>>> Hello Daniel,
>>>>
>>>> thanks a lot for your patches.
>>>>
>>>> You address the uefi-sct/SctPkg/TestCase/UEFI/EFI directory.
>>>>
>>>> Are you planning future patches for uefi-sct/SctPkg/TestCase/UEFI/IHV
>>>> too?
>>>
>>> I grepped the repo for strings related to arm64 and aarch64. I ported
>>> what I found.
>>> Do you see anything that's not ported?
>>
>> uefi-sct/SctPkg/UEFI/IHV_SCT.dsc is the only IHV related file with
>> AARCH64 in it and that one is covered by your patch series.
>>
>>>
>>> The only thing I see, is in
>>> Protocol/UsbIo/BlackBoxTest/UsbIoTestConformance.c
>>> where some code is not used for ARM because:
>>>
>>>    // Note: This function uses the EDKII Glu library from EDKII
>>> compatibility pkg.
>>>
>>>    // which is not ported to ARM yet. Hence for the time being just
>>> return success.
>>>
>>>
>>> I'm not yet sure what library that's referring to, but most likely it's
>>> also
>>> not implemented for RISC-V.
>>
>> I assume this refers to:
>> https://github.com/tianocore/edk/tree/master/Foundation/Library/EdkIIGlueLib
>>
>>
>> The files of this library are in edk2/MdePkg/Library now.
>
> Wow, that code is ancient then. I'm not gonna ifdef it out for RISC-V.
> If it works for x86 it might work for RISC-V now.
> Maybe the ARM people can try it on ARM first ;)
>
>>> Thanks for testing!
>>> Does the SCT result look like what you expect? Or are some tests failing
>>> that you expect to succeed?
>>
>> Not all tests have run yet. Running SCT on QEMU is really slow.
>>
>> But from what I can see there is no difference to AARCH64 results on
>> QEMU.
>
> Sounds great! I assume all the tests have succeeded now?

The SCT version built for RISC-V with you patches returned equivalent
results to ARM for U-Boot.

Best regards

Heinrich