From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by mx.groups.io with SMTP id smtpd.web12.49.1612799465947335760 for ; Mon, 08 Feb 2021 07:51:06 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmx.net header.s=badeba3b8450 header.b=Aq71mLM2; spf=pass (domain: gmx.de, ip: 212.227.17.21, mailfrom: xypron.glpk@gmx.de) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1612799434; bh=ApbmWsYB2v/GtvfkFq2HYX6XL1lDyaIatTSLFca92yY=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=Aq71mLM2Fje6/quao4m/zlcx0162WRv53XpJ530LpqC8VozCD+JvtEJeU+TFalY+9 yoQcOUkuZjY04WSlX3l+NWzLjRpLsfQQOvKge5+n8kCUXuwEcBdjGWC5rDsT90XYOj lEUSO2XZKFceNHeHG73eWILdpJcG4LqGaC0O0tXw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.70] ([62.143.246.89]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MAfYm-1l2ZEo2nxg-00B1dd; Mon, 08 Feb 2021 16:50:34 +0100 Subject: Re: [edk2-test PATCH v1 0/2] Add RISCV64 support to SctPkg To: Daniel Schaefer , devel@edk2.groups.io Cc: Leif Lindholm , Abner Chang , Gilbert Chen , Eric Jin , G Edhaya Chandran , Barton Gao , Samer El-Haj-Mahmoud References: <20201201161752.23734-1-daniel.schaefer@hpe.com> <82ec80ae-679e-ae37-6a13-8ef957789a7b@gmx.de> <1cd523be-3f74-206e-bcdb-9d05f85b717e@hpe.com> From: "Heinrich Schuchardt" Message-ID: Date: Mon, 8 Feb 2021 16:50:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <1cd523be-3f74-206e-bcdb-9d05f85b717e@hpe.com> X-Provags-ID: V03:K1:6tm7gWBVK9cAZUnlrYXTbKrb52Y8VfDIxSUeNGpcm1Ykvi1c+HY AKWr8c3xxlZLWF6/D8+QPIB7DQDpbIp3WQtTfVqwRjboBjjvLVgSPi2kIHkNWKGf6RE5yYc r62LyK2vbn/W7KVKJnb35zxW6PkK1PLEig1+/zSTA4hvmwr/RTY0pbHpHjah2KtdDyV7Ezm vR26NaUi7ei+dMEHdTyjQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:E1o1Tyjt5A4=:8p3+HJRBcN1mifPmQbS5cl sbxEpuSQKq+pLa5jqJeVEineXS8iwQP2OKPYzirWUoEslQXaaUhBAXqo0D5l8FUkqEnwmmp74 P+VeC/mYJpM2ChCANO/UOsDaUrW52vyKD+HxLyC0rEPcjo5ar6S3rEZVIinDSFEkt1xJbM2LB fp+9K0NYTbP1fgXLYCkqa/O0kk+nlyyMRFIPyYi+tGabBbMiDF5/cxZL/VEEG5p0qp0kX4JOJ MP0H+Py8eq+Dq+b1xZzQMNoSKbbALqq92cOeElizblX9fyfDvKi+GMqpQs1G1YKYScEzfOKSj Mh9NPaw1l7aek8EM7/Qdve7Xt7A1sCOVHzQ0SnKsDNoadkP0I2O3Ci1awe0U4Uh5CjJeRrk+M ZXcsuxl8fwZSuDOkimArnLWTUrXXPDY9PJ1s0SJ2X7SXsKUsmqt7vgQ9KPDaCKalYC4onex0U DKhryCjM3goXPe7SAvi4FE8jwEXDwvBecbriPoDcJ9OXCilj0le5StwQVnnRwbJNzHtm4Qi6X 4ktCY901meCnkB+Jq2PEt0WIDvOAnHpngFNHe4X77lMbs2CFxbHJ3GPw6w7ll6sqyEYp+L+AI yQGZhX/9ohT9VSSBnaE3wkhf3LGtsSYEUew9IuASQcqu03cJ2rSB4N423VKdRCmbWyOOfAM2U PqHhvR+pxRhPR7Edw/mkXNf/VAxNd+iMPw29HGvXtG05ufOB4uml53llv/TWQNvIcosq2Mx2p 4qkOf1k1biO6W1u4J6230Khp9dZ8Z5v32OtU+/pCxzahwpQI08OR2sutQ7eQ/je1gOZ72wFnj mzaG7AX58qUwi7vRQ1n5Uo5SiA2auOHPuLwBdFDrTujWht19HSaPXqrqjV3EY2UlHdBz4myug H9RH9jX74Xk64ZOIwzcA== Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 08.02.21 15:30, Daniel Schaefer wrote: > On 12/2/20 1:37 AM, Heinrich Schuchardt wrote: >> On 12/1/20 6:11 PM, Daniel Schaefer wrote: >>> On 12/2/20 12:59 AM, Heinrich Schuchardt wrote: >>>> On 12/1/20 5:17 PM, Daniel Schaefer wrote: >>>>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3042 >>>>> >>>>> With this patch series we can build the UEFI SCT for RISCV64. It was >>>>> confirmed >>>>> to be working on the U-Boot UEFI implementation by Heinrich. >>>>> It hasn't been tested on EDK2 yet. >>>>> >>>>> Build requirements are the same as for the EDK2 RISCV64 port and >>>>> detailed here: >>>>> https://github.com/riscv/riscv-uefi-edk2-docs >>>>> >>>>> The second patch is a big one because it adds architecture specific >>>>> files by >>>>> copying them from the Aarch64 directory. Only a single file, an >>>>> assembly file >>>>> needed modifications. I'm not sure why the other ones are in an >>>>> architecture >>>>> specific directory. They're all C files and seem to be generic. We >>>>> can probably >>>>> unify them. >>>> >>>> Hello Daniel, >>>> >>>> thanks a lot for your patches. >>>> >>>> You address the uefi-sct/SctPkg/TestCase/UEFI/EFI directory. >>>> >>>> Are you planning future patches for uefi-sct/SctPkg/TestCase/UEFI/IHV >>>> too? >>> >>> I grepped the repo for strings related to arm64 and aarch64. I ported >>> what I found. >>> Do you see anything that's not ported? >> >> uefi-sct/SctPkg/UEFI/IHV_SCT.dsc is the only IHV related file with >> AARCH64 in it and that one is covered by your patch series. >> >>> >>> The only thing I see, is in >>> Protocol/UsbIo/BlackBoxTest/UsbIoTestConformance.c >>> where some code is not used for ARM because: >>> >>> =C2=A0=C2=A0 // Note: This function uses the EDKII Glu library from ED= KII >>> compatibility pkg. >>> >>> =C2=A0=C2=A0 // which is not ported to ARM yet. Hence for the time bei= ng just >>> return success. >>> >>> >>> I'm not yet sure what library that's referring to, but most likely it'= s >>> also >>> not implemented for RISC-V. >> >> I assume this refers to: >> https://github.com/tianocore/edk/tree/master/Foundation/Library/EdkIIGl= ueLib >> >> >> The files of this library are in edk2/MdePkg/Library now. > > Wow, that code is ancient then. I'm not gonna ifdef it out for RISC-V. > If it works for x86 it might work for RISC-V now. > Maybe the ARM people can try it on ARM first ;) > >>> Thanks for testing! >>> Does the SCT result look like what you expect? Or are some tests faili= ng >>> that you expect to succeed? >> >> Not all tests have run yet. Running SCT on QEMU is really slow. >> >> But from what I can see there is no difference to AARCH64 results on >> QEMU. > > Sounds great! I assume all the tests have succeeded now? The SCT version built for RISC-V with you patches returned equivalent results to ARM for U-Boot. Best regards Heinrich