From: "Marcin Juszkiewicz" <marcin.juszkiewicz@linaro.org>
To: Laszlo Ersek <lersek@redhat.com>,
edk2-devel-groups-io <devel@edk2.groups.io>,
Michael Kubacki <mikuback@linux.microsoft.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>,
Pedro Falcato <pedro.falcato@gmail.com>,
Andrew Fish <afish@apple.com>,
"Leif Lindholm (Quic)" <quic_llindhol@quicinc.com>
Subject: Re: [edk2-devel] edk2 uncrustify update (73.0.8)?
Date: Mon, 13 Nov 2023 13:29:53 +0100 [thread overview]
Message-ID: <b9281d57-31ef-42e2-aca3-c7dfe87a62a2@linaro.org> (raw)
In-Reply-To: <0107c96b-849a-db48-194b-1a4c1f3b0c78@redhat.com>
W dniu 13.11.2023 o 12:58, Laszlo Ersek pisze:
> Note that 73.0.3 indents the subexpression to the "//" comment on the
> previous line, while 73.0.8 ignores the comment -- which I think is
> justified here.
>
> I believe this improvement may come from uncrustify commit 239c4fad745b
> ("Prevent endless indentation scenario in struct assignment",
> 2022-07-29). I think it's worth having in edk2.
I like this.
> CC: stewards, Pedro (commit 6ded9f50c3aa), Marcin (traditionally a big
> fan of uncrustify :))
I prefer to have source formatter than not having it. Especially in
projects which have code style far from mine.
Still a fan of adding edk2-uncrustify to BaseTools. If we are expected
to use it then let it get installed at same moment as "build" command is.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111149): https://edk2.groups.io/g/devel/message/111149
Mute This Topic: https://groups.io/mt/102559740/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-11-13 12:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 11:58 [edk2-devel] edk2 uncrustify update (73.0.8)? Laszlo Ersek
2023-11-13 12:29 ` Marcin Juszkiewicz [this message]
2023-11-13 19:14 ` Rebecca Cran via groups.io
2023-11-13 20:37 ` Michael Kubacki
2023-11-13 19:07 ` Pedro Falcato
2023-11-13 20:21 ` Michael Kubacki
2023-11-13 21:05 ` Michael D Kinney
2023-11-14 14:51 ` Laszlo Ersek
2023-11-14 15:12 ` Rebecca Cran via groups.io
2023-11-15 8:52 ` Laszlo Ersek
[not found] ` <17974449E158DE38.1153@groups.io>
2023-11-13 19:10 ` Pedro Falcato
2023-11-13 20:08 ` Michael Kubacki
2023-11-13 20:37 ` Rebecca Cran
2023-11-13 21:33 ` Pedro Falcato
2023-11-14 15:01 ` Laszlo Ersek
2023-11-16 8:29 ` Pedro Falcato
2023-11-16 17:36 ` Michael Kubacki
2023-11-23 2:07 ` Pedro Falcato
2023-11-17 9:08 ` Laszlo Ersek
2023-11-23 1:44 ` Pedro Falcato
2023-11-14 1:46 ` Michael Kubacki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9281d57-31ef-42e2-aca3-c7dfe87a62a2@linaro.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox