From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 20BCEAC1244 for ; Mon, 13 Nov 2023 12:29:58 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=8mxdBGqm+Q/qDzFinegfaiEu1cr8XUr2W2jNg7FzKGQ=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:Organization:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1699878597; v=1; b=OL8W1d0a1Qrh3iMq+/LrZ5a+rlTwWtUukSkTL5IjTkzJ5+sz6yyJGYRoLknJBdXzu1FEeaRl P8fO6Cz+YOby49nABK7YkC9Pbap2WMx1u2djeq0TCc7G5A2AkH67zseb59EuWWp5wZbRn+QVZV4 QJ4bFQKsrErMppRlEep9z8bQ= X-Received: by 127.0.0.2 with SMTP id ksXzYY7687511xX5TCCjnVB2; Mon, 13 Nov 2023 04:29:57 -0800 X-Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by mx.groups.io with SMTP id smtpd.web11.35643.1699878596942625846 for ; Mon, 13 Nov 2023 04:29:57 -0800 X-Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-53e08e439c7so7215067a12.0 for ; Mon, 13 Nov 2023 04:29:56 -0800 (PST) X-Gm-Message-State: b2awI3xCUiI7WpFIl2ppmVn1x7686176AA= X-Google-Smtp-Source: AGHT+IHGsBxaQQ/+JSOj1JfsOFNnkpOxyYhbbtNLYtLSojoK1suieibCHSqPeD0AWxqZAbd6iC5+dQ== X-Received: by 2002:a05:6402:d09:b0:547:6643:5dfb with SMTP id eb9-20020a0564020d0900b0054766435dfbmr1338634edb.42.1699878595387; Mon, 13 Nov 2023 04:29:55 -0800 (PST) X-Received: from [192.168.200.206] (83.11.210.67.ipv4.supernova.orange.pl. [83.11.210.67]) by smtp.gmail.com with ESMTPSA id d17-20020aa7c1d1000000b0052febc781bfsm3668664edp.36.2023.11.13.04.29.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Nov 2023 04:29:55 -0800 (PST) Message-ID: Date: Mon, 13 Nov 2023 13:29:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] edk2 uncrustify update (73.0.8)? To: Laszlo Ersek , edk2-devel-groups-io , Michael Kubacki Cc: Michael Kinney , Pedro Falcato , Andrew Fish , "Leif Lindholm (Quic)" References: <0107c96b-849a-db48-194b-1a4c1f3b0c78@redhat.com> From: "Marcin Juszkiewicz" Organization: Linaro In-Reply-To: <0107c96b-849a-db48-194b-1a4c1f3b0c78@redhat.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,marcin.juszkiewicz@linaro.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Language: pl-PL, en-GB, en-HK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=OL8W1d0a; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linaro.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io W dniu 13.11.2023 o 12:58, Laszlo Ersek pisze: > Note that 73.0.3 indents the subexpression to the "//" comment on the > previous line, while 73.0.8 ignores the comment -- which I think is > justified here. > > I believe this improvement may come from uncrustify commit 239c4fad745b > ("Prevent endless indentation scenario in struct assignment", > 2022-07-29). I think it's worth having in edk2. I like this. > CC: stewards, Pedro (commit 6ded9f50c3aa), Marcin (traditionally a big > fan of uncrustify :)) I prefer to have source formatter than not having it. Especially in projects which have code style far from mine. Still a fan of adding edk2-uncrustify to BaseTools. If we are expected to use it then let it get installed at same moment as "build" command is. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111149): https://edk2.groups.io/g/devel/message/111149 Mute This Topic: https://groups.io/mt/102559740/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-