From: "Rebecca Cran" <rebecca@bsdio.com>
To: "Richard Ho (何明忠)" <RichardHo@ami.com>
Cc: "Andrew Fish" <afish@apple.com>,
"Leif Lindholm" <quic_llindhol@quicinc.com>,
"Michael D Kinney" <michael.d.kinney@intel.com>,
"Michael Kubacki" <mikuback@linux.microsoft.com>,
"Zhiguang Liu" <zhiguang.liu@intel.com>,
"Liming Gao" <gaoliming@byosoft.com.cn>,
"Tinh Nguyen" <tinhnguyen@os.amperecomputing.com>,
"Tony Lo (羅金松)" <TonyLo@ami.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [PATCH v7 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support
Date: Wed, 19 Apr 2023 10:34:26 -0600 [thread overview]
Message-ID: <b992e761-c385-efee-d2f2-13a5c17e2258@bsdio.com> (raw)
In-Reply-To: <20e340f2-c5bb-10b1-f286-0c52afffb74f@bsdio.com>
Hi Richard,
I was wondering if you'd seen my questions about ECM and NCM, and rate
limiting?
--
Rebecca Cran
On 4/11/23 6:31 AM, Rebecca Cran wrote:
> Yes, you can add me as a reviewer.
>
> A couple more comments on the patches: why are ECM and NCM disabled by
> default?
>
> I've tested on my Juno R2 system and it appears rate limiting is
> required, so should it be enabled by default?
>
>
> Given this is adding a new top-level package, I'd like to see a
> review/feedback from the TianoCore Stewards.
>
>
next prev parent reply other threads:[~2023-04-19 16:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 11:27 [PATCH v7 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support RichardHo [何明忠]
2023-04-07 11:27 ` [PATCH v7 2/3] UsbNetworkPkg/UsbCdcEcm: Add USB Cdc ECM " RichardHo [何明忠]
2023-04-07 11:27 ` [PATCH v7 3/3] UsbNetworkPkg/UsbCdcNcm: Add USB Cdc NCM " RichardHo [何明忠]
2023-04-10 16:02 ` [PATCH v7 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS " Rebecca Cran
2023-04-11 2:21 ` RichardHo [何明忠]
2023-04-11 5:08 ` [edk2-devel] " Chang, Abner
2023-04-11 12:31 ` Rebecca Cran
2023-04-11 12:38 ` [edk2-devel] " Pedro Falcato
2023-04-12 2:26 ` RichardHo [何明忠]
2023-04-12 4:25 ` Chang, Abner
2023-04-13 2:33 ` RichardHo [何明忠]
2023-04-18 17:16 ` Leif Lindholm
2023-04-19 16:34 ` Rebecca Cran [this message]
2023-04-20 1:55 ` RichardHo [何明忠]
2023-04-11 15:20 ` Rebecca Cran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b992e761-c385-efee-d2f2-13a5c17e2258@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox