From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mx.groups.io with SMTP id smtpd.web11.43090.1681922070417567683 for ; Wed, 19 Apr 2023 09:34:30 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm1 header.b=FbgFZVxD; spf=pass (domain: bsdio.com, ip: 66.111.4.28, mailfrom: rebecca@bsdio.com) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id ABE1B5C01BD; Wed, 19 Apr 2023 12:34:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 19 Apr 2023 12:34:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1681922069; x=1682008469; bh=2sg+0XULBir/4qKUdkN3o18EnuH8/uPki29 fPlU5pdk=; b=FbgFZVxDSrMEwRFzzFkunmzTe0A+TP0wqkNsblkvmlP3Z7q451t tKzaf+3HntxJ3JQJJ75UBh1bxuem9Ks2EOmwG25GDdedi6JhLhvOBLmXo0pAaAyf HBL9Ph1006ZvO/ifnHUJZFOfoVkcFTwnkvEaLzhz4/jLbxjrnMnnJrJIc4V4NGOe gbush0Y/fEyDM11S+hjdHpnEPu4so/OpbpFqbXr2fRHBkQBG1tRmUmj0wxOuyG7t pYkqwR8fjqSSAb+UFaO+sIK+cPHL99uRtiyNEkbFxYyTGoTcfk8gBtul5W4pM3/s E+rHfaOi+l6DSOJ2si8YCY4ndYtcqYtFzTQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1681922069; x=1682008469; bh=2sg+0XULBir/4qKUdkN3o18EnuH8/uPki29 fPlU5pdk=; b=M5ZixkLFGWbG0xnlKzfVUJW35ua/vsoaEMobvNiMt/ughOy1bsE V8npP1/QdSYoFwmwN7B7ATd8QvFjSBZIKpGmG6cJXachs1Clx8mh9A0UB/PdPIWK XZEAXGZ7nlhjpSO87/llwHRD5wJBKg7SQU38TuwKpha/xpCy7iLve9/luUq/ONBm rl6fKFrhZBg+B82YTjxmOcSQyu6vPUnfvWuESWrc79QdUwtvg42fjLrTRh5/YEsx ZpLF2L9Xeh/XDGHXzFSPEMuEO9es1VJjv+hUfjd1x+k+Cqnsa7ClYd8fChrE4VAP Dc0406c1+OatBO3Pk1gduq3eWtWCkK/sIZA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedttddguddtgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuhffvvehfjggtgfesthejredttdefjeenucfhrhhomheptfgv sggvtggtrgcuvehrrghnuceorhgvsggvtggtrgessghsughiohdrtghomheqnecuggftrf grthhtvghrnhepteetffffffetiefghedvueehveffheetleehgfduueffudeigedvvedu leetfefhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprhgvsggvtggtrgessghsughiohdrtghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 19 Apr 2023 12:34:27 -0400 (EDT) Message-ID: Date: Wed, 19 Apr 2023 10:34:26 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v7 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support From: "Rebecca Cran" To: =?UTF-8?B?UmljaGFyZCBIbyAo5L2V5piO5b+gKQ==?= Cc: Andrew Fish , Leif Lindholm , Michael D Kinney , Michael Kubacki , Zhiguang Liu , Liming Gao , Tinh Nguyen , =?UTF-8?B?VG9ueSBMbyAo576F6YeR5p2+KQ==?= , "devel@edk2.groups.io" References: <20230407112638.405-1-richardho@ami.com> <20e340f2-c5bb-10b1-f286-0c52afffb74f@bsdio.com> In-Reply-To: <20e340f2-c5bb-10b1-f286-0c52afffb74f@bsdio.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Richard, I was wondering if you'd seen my questions about ECM and NCM, and rate limiting? -- Rebecca Cran On 4/11/23 6:31 AM, Rebecca Cran wrote: > Yes, you can add me as a reviewer. > > A couple more comments on the patches: why are ECM and NCM disabled by > default? > > I've tested on my Juno R2 system and it appears rate limiting is > required, so should it be enabled by default? > > > Given this is adding a new top-level package, I'd like to see a > review/feedback from the TianoCore Stewards. > >