From: "GuoMinJ" <newexplorerj@gmail.com>
To: devel@edk2.groups.io
Cc: GuoMinJ <newexplorerj@gmail.com>,
Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <liming.gao@intel.com>
Subject: [PATCH v3] MdePkg/UnitTestBaseLib: Add check for pointer BinData
Date: Thu, 5 Mar 2020 13:58:16 +0800 [thread overview]
Message-ID: <b9a84e161dc88ec310090c91b5033518c7711c3e.1583387883.git.newexplorerj@gmail.com> (raw)
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2531
AllocatePool may fail and BinData may be invalid, check
it before use.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
---
MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c b/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c
index 6f7c31cab4..933d2b40e0 100644
--- a/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c
+++ b/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c
@@ -252,6 +252,9 @@ RfcDecodeTest(
BinSize = AsciiStrnLenS (binString, MAX_TEST_STRING_SIZE);
BinData = AllocatePool (BinSize);
+ if (BinData == NULL) {
+ return UNIT_TEST_ERROR_TEST_FAILED;
+ }
Btc->BufferToFree = BinData;
ReturnSize = BinSize;
--
2.17.1
next reply other threads:[~2020-03-05 5:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 5:58 GuoMinJ [this message]
2020-03-23 6:11 ` [edk2-devel] [PATCH v3] MdePkg/UnitTestBaseLib: Add check for pointer BinData Guomin Jiang
2020-03-23 13:33 ` Liming Gao
2020-03-23 18:16 ` Michael D Kinney
2020-03-23 21:54 ` Bret Barkelew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9a84e161dc88ec310090c91b5033518c7711c3e.1583387883.git.newexplorerj@gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox