From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by mx.groups.io with SMTP id smtpd.web11.8774.1583387956291097600 for ; Wed, 04 Mar 2020 21:59:16 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=UxOiF8Fs; spf=pass (domain: gmail.com, ip: 209.85.216.51, mailfrom: newexplorerj@gmail.com) Received: by mail-pj1-f51.google.com with SMTP id s8so2039540pjq.0 for ; Wed, 04 Mar 2020 21:59:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=QPgRlM6bpzXNetTNz1+0hcFhanmTUXag0E/0wycErZ4=; b=UxOiF8FsVqgfxy+B2p4zSgrGj14Fr6iQGiTDAp95JGbOvUVWHmq5t+zaZYrhHpqnrL /abWEHWPUf1a5A0ZIc4R1IyjWsLUwXYr/F7ha4fQdY/jlqo2AbghiE/oLQ3xLPB+fU0Z RZF3Ne2PwBEOzrpzr0aAQ/TevMD2ISOwClzt+1XZxrgdk7e33jH4mMh9cDlsSIPUgOCe rf2dNZCoeDUBV+1wlpiAWtNohTpwz3rPGSTJB2Nv1Bd6pz9ZvQHDkZZL1diVnp2Qlr8M 1AiPZBLmwSXyK7eYZDFQ6XfSJ3v9mnp/9YH3r/20Ypm0yixnG15s/jkY5JFwZGqvYJTs f7Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=QPgRlM6bpzXNetTNz1+0hcFhanmTUXag0E/0wycErZ4=; b=GgYiGhuDdS8/p/wz2akzj7YQ9Wg2K9WN3UXvrpoTWvDNQBRy0hiAnsuF2Mq3uqaIeF YI0n2DjsNBhgEYKB8XNC782ktTZuiIIv8UTx7VHI2FQce1KIDhYpiO7f4fh1+9wuc1hg /5vVzT6V4dcVTrocosyu/7tGF2bG8Lu817fa3tYk3lC6wWVvdqY/iyaASz9RuNj+tmbH Kvovb5dZXtoiwqHScjldPlYOifUkSHJkMzrnBjNiX0Oz9Ob/+WsG8YSCd8+7pHLoToiC bXjwk4IkSVxx0XNUA8q/9+1fmPt7+B/kG5z+OHGlAw5fh6SByJgLqJqC9BQUOLZfhHtf NNRQ== X-Gm-Message-State: ANhLgQ2KJcbF/84Cy6WXMypds3Lm/CPkJrHsufWHy/QVemFmg98b3crb 4+KKpLuJai3wn6njnZbJQcI9wQHYKu4rWg== X-Google-Smtp-Source: ADFU+vtqSjGh7d0Bl6kK0t0zUSbuHfIcrK6DTtT8sQTubFHi9peeIC9FyApzKSmkL/nx0slbb9H5Qg== X-Received: by 2002:a17:902:8a8e:: with SMTP id p14mr6457648plo.28.1583387955163; Wed, 04 Mar 2020 21:59:15 -0800 (PST) Return-Path: Received: from localhost.localdomain ([222.67.15.87]) by smtp.gmail.com with ESMTPSA id r24sm4398994pfg.61.2020.03.04.21.59.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2020 21:59:14 -0800 (PST) From: "GuoMinJ" To: devel@edk2.groups.io Cc: GuoMinJ , Michael D Kinney , Liming Gao Subject: [PATCH v3] MdePkg/UnitTestBaseLib: Add check for pointer BinData Date: Thu, 5 Mar 2020 13:58:16 +0800 Message-Id: X-Mailer: git-send-email 2.17.1 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2531 AllocatePool may fail and BinData may be invalid, check it before use. Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: GuoMinJ --- MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c b/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c index 6f7c31cab4..933d2b40e0 100644 --- a/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c +++ b/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c @@ -252,6 +252,9 @@ RfcDecodeTest( BinSize = AsciiStrnLenS (binString, MAX_TEST_STRING_SIZE); BinData = AllocatePool (BinSize); + if (BinData == NULL) { + return UNIT_TEST_ERROR_TEST_FAILED; + } Btc->BufferToFree = BinData; ReturnSize = BinSize; -- 2.17.1