From: "David Woodhouse" <dwmw2@infradead.org>
To: Laszlo Ersek <lersek@redhat.com>,
devel@edk2.groups.io, Mike Maslenkin <mihailm@parallels.com>
Subject: Re: [edk2-devel] [edk2] [PATCH] OvmfPkg: QemuVideoDxe: Int10h stub for Windows 2008 R2 SP1 (stdvga, QXL)
Date: Thu, 20 Jun 2019 17:08:32 +0100 [thread overview]
Message-ID: <b9ad799f10c23ce4c5451708825245bdd2c75567.camel@infradead.org> (raw)
In-Reply-To: <920cf69f-8ec8-616a-4a07-9e93e88f81b6@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1499 bytes --]
On Thu, 2019-06-20 at 16:41 +0200, Laszlo Ersek wrote:
> On 06/20/19 10:59, David Woodhouse wrote:
> > On Wed, 2019-06-19 at 23:57 +0200, Laszlo Ersek wrote:
> > > In 2013, you submitted the following patch:
> > >
> > > OvmfPkg: Don't build in QemuVideoDxe when we have CSM
> > >
> > > The thread starts here:
> > >
> > > https://www.mail-archive.com/edk2-devel@lists.sourceforge.net/msg01871.html
> > >
> > > After an update:
> > >
> > > http://mid.mail-archive.com/1360493281.7383.26.camel@shinybook.infradead.org
> > >
> > > I had given my R-b:
> > >
> > > http://mid.mail-archive.com/511816AD.9000603@redhat.com
> > >
> > > But, the patch was never merged.
> > >
> > > The commit hash referenced in those messages still works (pointing into your personal repo):
> > >
> > > http://git.infradead.org/users/dwmw2/edk2.git/commitdiff/22253c949e5
> > >
> > > Can you resubmit that patch please?
> >
> >
> > Makes sense. I've pushed it to
> > http://git.infradead.org/users/dwmw2/edk2.git/shortlog/refs/heads/csm
>
> Thanks -- it looks good to me (a09db38a866a).
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>
> Still, can you please post the patch to the list, for review?
Sure! That wasn't meant to be an implicit pull request; just an interim
response while I get my act together and put together the rest of that
series including some other CSM fixes. The first two patches there have
already been posted in email, FWIW.
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5174 bytes --]
next prev parent reply other threads:[~2019-06-20 16:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1399571116-26442-1-git-send-email-lersek@redhat.com>
[not found] ` <CAFe8ug8xKBXpvwP_O1AdzC1Ph4hYhp6PMRX+SmaBXaWxZ2J5VQ@mail.gmail.com>
[not found] ` <5370CA20.1030504@redhat.com>
[not found] ` <1399911663.21359.36.camel@mg-think.sw.ru>
2019-06-17 10:52 ` [edk2] [PATCH] OvmfPkg: QemuVideoDxe: Int10h stub for Windows 2008 R2 SP1 (stdvga, QXL) David Woodhouse
2019-06-19 21:57 ` Laszlo Ersek
2019-06-20 8:59 ` David Woodhouse
2019-06-20 14:41 ` [edk2-devel] " Laszlo Ersek
2019-06-20 16:08 ` David Woodhouse [this message]
2019-06-24 13:10 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9ad799f10c23ce4c5451708825245bdd2c75567.camel@infradead.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox