On Thu, 2019-06-20 at 16:41 +0200, Laszlo Ersek wrote: > On 06/20/19 10:59, David Woodhouse wrote: > > On Wed, 2019-06-19 at 23:57 +0200, Laszlo Ersek wrote: > > > In 2013, you submitted the following patch: > > > > > > OvmfPkg: Don't build in QemuVideoDxe when we have CSM > > > > > > The thread starts here: > > > > > > https://www.mail-archive.com/edk2-devel@lists.sourceforge.net/msg01871.html > > > > > > After an update: > > > > > > http://mid.mail-archive.com/1360493281.7383.26.camel@shinybook.infradead.org > > > > > > I had given my R-b: > > > > > > http://mid.mail-archive.com/511816AD.9000603@redhat.com > > > > > > But, the patch was never merged. > > > > > > The commit hash referenced in those messages still works (pointing into your personal repo): > > > > > > http://git.infradead.org/users/dwmw2/edk2.git/commitdiff/22253c949e5 > > > > > > Can you resubmit that patch please? > > > > > > Makes sense. I've pushed it to > > http://git.infradead.org/users/dwmw2/edk2.git/shortlog/refs/heads/csm > > Thanks -- it looks good to me (a09db38a866a). > > Reviewed-by: Laszlo Ersek > > Still, can you please post the patch to the list, for review? Sure! That wasn't meant to be an implicit pull request; just an interim response while I get my act together and put together the rest of that series including some other CSM fixes. The first two patches there have already been posted in email, FWIW.