From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 69428211F35C9 for ; Wed, 3 Apr 2019 05:48:28 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E8E523082E60; Wed, 3 Apr 2019 12:48:27 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-127.rdu2.redhat.com [10.10.120.127]) by smtp.corp.redhat.com (Postfix) with ESMTP id E1DF3608A5; Wed, 3 Apr 2019 12:48:26 +0000 (UTC) To: Hao Wu , edk2-devel@lists.01.org Cc: Jordan Justen , David Woodhouse References: <20190403070036.1404-1-hao.a.wu@intel.com> <20190403070036.1404-6-hao.a.wu@intel.com> From: Laszlo Ersek Message-ID: Date: Wed, 3 Apr 2019 14:48:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190403070036.1404-6-hao.a.wu@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Wed, 03 Apr 2019 12:48:28 +0000 (UTC) Subject: Re: [RFC PATCH v1 5/8] OvmfPkg/AcpiPlatformDxe: Consume the 8259 PCD defined in OvmfPkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Apr 2019 12:48:28 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 04/03/19 09:00, Hao Wu wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1496 > > Several updates have been made to the OvmfPkg/AcpiPlatformDxe driver to > drop its dependency on PcAtChipsetPkg: > > A) Consumes the PCD 'Pcd8259LegacyModeEdgeLevel' defined within OvmfPkg; > B) Remove the PcAtChipsetPkg DEC file dependency in the driver INF file. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: David Woodhouse > Cc: Ray Ni > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Hao Wu > --- > OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf b/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf > index 8440e7b343..24e2c0373f 100644 > --- a/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf > +++ b/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf > @@ -1,7 +1,7 @@ > ## @file > # OVMF ACPI Platform Driver > # > -# Copyright (c) 2008 - 2018, Intel Corporation. All rights reserved.
> +# Copyright (c) 2008 - 2019, Intel Corporation. All rights reserved.
> # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the BSD License > # which accompanies this distribution. The full text of the license may be found at > @@ -42,7 +42,6 @@ > MdeModulePkg/MdeModulePkg.dec > OvmfPkg/OvmfPkg.dec > UefiCpuPkg/UefiCpuPkg.dec > - PcAtChipsetPkg/PcAtChipsetPkg.dec > > [LibraryClasses] > UefiLib > @@ -72,7 +71,7 @@ > gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiTableStorageFile > gEfiMdeModulePkgTokenSpaceGuid.PcdPciDisableBusEnumeration > gUefiCpuPkgTokenSpaceGuid.PcdCpuLocalApicBaseAddress > - gPcAtChipsetPkgTokenSpaceGuid.Pcd8259LegacyModeEdgeLevel > + gUefiOvmfPkgTokenSpaceGuid.Pcd8259LegacyModeEdgeLevel > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFdBaseAddress > > [Depex] > Reviewed-by: Laszlo Ersek