[edk2-devel] ASSERT(FALSE) at the end of a void function "PciHostBridgeResourceConflict" from "MinPlatformPkg"

[edk2-devel] ASSERT(FALSE) at the end of a void function "PciHostBridgeResourceConflict" from "MinPlatformPkg"

[memristor2 via groups.io]

[-- Attachment #1: Type: text/plain, Size: 2733 bytes --]

Hello everyone,
I was trying to get my platform running and since I used MinPlatformPkg as my base platform I used the
Platform/Intel/MinPlatformPkg/Pci/Library/PciHostBridgeLibSimple/PciHostBridgeLibSimple.inf for the library of the MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf component. the thing was that my platform would execute through PciEnumerator then PciHostBridgeResourceAllocator then would get stuck when calling the NotifyPhase (PciResAlloc, EfiPciHostBridgeAllocateResources); So I checked the switch case routine looking for the EfiPciHostBridgeAllocateResources literal and I realized the "PciHostBridgeResourceConflict" is as following:
VOID
EFIAPI
PciHostBridgeResourceConflict (
EFI_HANDLE HostBridgeHandle,
VOID *Configuration
)
{
EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR *Descriptor;
UINTN RootBridgeIndex;
DEBUG ((DEBUG_ERROR, "PciHostBridge: Resource conflict happens!\n"));
RootBridgeIndex = 0;
Descriptor = (EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR *) Configuration;
while (Descriptor->Desc == ACPI_ADDRESS_SPACE_DESCRIPTOR) {
DEBUG ((DEBUG_ERROR, "RootBridge[%d]:\n", RootBridgeIndex++));
for (; Descriptor->Desc == ACPI_ADDRESS_SPACE_DESCRIPTOR; Descriptor++) {
ASSERT (Descriptor->ResType <
sizeof (mPciHostBridgeLibAcpiAddressSpaceTypeStr) / sizeof (mPciHostBridgeLibAcpiAddressSpaceTypeStr[0])
);
DEBUG ((DEBUG_ERROR, " %s: Length/Alignment = 0x%lx / 0x%lx\n",
mPciHostBridgeLibAcpiAddressSpaceTypeStr[Descriptor->ResType], Descriptor->AddrLen, Descriptor->AddrRangeMax));
if (Descriptor->ResType == ACPI_ADDRESS_SPACE_TYPE_MEM) {
DEBUG ((DEBUG_ERROR, " Granularity/SpecificFlag = %ld / %02x%s\n",
Descriptor->AddrSpaceGranularity, Descriptor->SpecificFlag,
((Descriptor->SpecificFlag & EFI_ACPI_MEMORY_RESOURCE_SPECIFIC_FLAG_CACHEABLE_PREFETCHABLE) != 0) ? L" (Prefetchable)" : L""
));
}
}
//
// Skip the END descriptor for root bridge
//
ASSERT (Descriptor->Desc == ACPI_END_TAG_DESCRIPTOR);
Descriptor = (EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR *) ((EFI_ACPI_END_TAG_DESCRIPTOR *) Descriptor + 1);
}
ASSERT (FALSE);}
So my question is what is going on with this line "ASSERT(FALSE)" must it stop the platform from executing further? if so, why other libraries which define this function don't have this line? I could simply comment it out but I would rather get a sense of what's going on

Sent with [Proton Mail](https://proton.me/) secure email.

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118097): https://edk2.groups.io/g/devel/message/118097
Mute This Topic: https://groups.io/mt/105670505/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 5758 bytes --]