From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (NAM04-DM6-obe.outbound.protection.outlook.com [40.107.102.62]) by mx.groups.io with SMTP id smtpd.web12.9789.1597325276761234468 for ; Thu, 13 Aug 2020 06:27:56 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amdcloud.onmicrosoft.com header.s=selector2-amdcloud-onmicrosoft-com header.b=H5foL2rq; spf=none, err=SPF record not found (domain: amd.com, ip: 40.107.102.62, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dcz8PF/cBAa43VIe5RAxre4LN95OO0b9mg2YeayBdYAVKn2MQD7YYgwVZR4pV8rqAEvNDmVFqTPMg7Yhx3qywVx0VXAUNm9dq04hdPWd4zpWvcyezMhf8LxTVfQ75RHczvq4h+I3ZTefY+PJVUx/qkCo+eYJukHnAUKacoWf0zfHsTGbiIhfuMW1S6Q7N6yfFmxVNj8H7XMNYCfJuShiu6k8BFgVmVHtZs033+U2D+a3kYnVqI+zGOUfSZh4uVA920aw/5KoIc9/syrtEHvGnvNBVVPtco95yT6hWRKLmtlVcjzKEjjd/AqFYSJJ8l5F6fHjziN9Z8J9gVEWw+DLmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZUhcZxPmmmeqgCcFESoU2i/0Nfo+5EuDwiePt8nunSE=; b=jhD0BDC27plpEYjqzmhuhzHnF2aonzspm/zojEkIidyPiXJHZqOMvt9fYRkURnc1F1a4V5JRLyi12KTdmawZeZXHcFJkOYDY2fUIaH6qlSiNTu3zoFPkJget8bY3k2kBXd85NGEyQylhP6PYyRAGSw0/e4IhF9P5Hkt9cl/6bYKbnbfEDxTfut7GTVx8ekypju3Q7VXttbSJUewRkXlqDhzAKAlk5O5cL6/RN2q6dRw3RIBaD2lOkge6NlHO1OnYl5RhXeWMkzRrx+7BozWMbjfBEhTKfX4aNdO/aupJ+GNrcIXU+ysPWffRVxrCJ2cU3HBQUYuTNTgaP9RxU4l9dA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZUhcZxPmmmeqgCcFESoU2i/0Nfo+5EuDwiePt8nunSE=; b=H5foL2rqqDT0p07s5cstOwyHy4bvWWau0nGmrYFdpO9TfIIMLhKFwRMsauRb6FKUJ/crJYQTcji4VIbX0L77S+iYoS+/ykUzjMUDB2fqVND35HpqjFVa9bUWUF3g+Sii1pYcY/rN+tES/IdoiKU4dUjnJ1ACr9R/HeXp8ITbtBA= Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=amd.com; Received: from DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) by DM6PR12MB4220.namprd12.prod.outlook.com (2603:10b6:5:21d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.15; Thu, 13 Aug 2020 13:27:55 +0000 Received: from DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::25ec:e6ba:197c:4eb0]) by DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::25ec:e6ba:197c:4eb0%8]) with mapi id 15.20.3261.025; Thu, 13 Aug 2020 13:27:55 +0000 From: "Lendacky, Thomas" To: devel@edk2.groups.io CC: Brijesh Singh , Ard Biesheuvel , Eric Dong , Jordan Justen , Laszlo Ersek , Liming Gao , Michael D Kinney , Ray Ni Subject: [PATCH v15 32/46] OvmfPkg/PlatformPei: Move early GDT into ram when SEV-ES is enabled Date: Thu, 13 Aug 2020 08:23:19 -0500 Message-ID: X-Mailer: git-send-email 2.28.0 In-Reply-To: References: X-ClientProxiedBy: DM5PR12CA0002.namprd12.prod.outlook.com (2603:10b6:4:1::12) To DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) Return-Path: thomas.lendacky@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from tlendack-t1.amd.com (165.204.77.1) by DM5PR12CA0002.namprd12.prod.outlook.com (2603:10b6:4:1::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.15 via Frontend Transport; Thu, 13 Aug 2020 13:27:54 +0000 X-Mailer: git-send-email 2.28.0 X-Originating-IP: [165.204.77.1] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 44852d01-ce21-4dde-dd70-08d83f8cafbd X-MS-TrafficTypeDiagnostic: DM6PR12MB4220: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rhhtzeWtBclPn4/iaIE96dXVA69wQajh47Q4XIg8JpQvZhNz4t4LpXjz6YTE8YwPQpdq0kw+l+FziF8hC6VDODG5n2c3BNcHV2DC/6+9n7CGQ2kZVi+Q09XPUep/wkr0HS/bUN3DwCe+N2ZRDgAdkRpwCtINfLC5rkZTnEBe8hxnZsjjZR1rWkt6bNxyEiD0+13JYHhmGiqVk0Ub3RpLHq7K1NjzdIpouYOxldUuJ5rZab7w6EFwTLUnKTPNnvkN3demFfgZBYl+pCFAk2wqpASQDapT35+fvGDZdsSELWUqLa2nkEdgYYwGZa6+SfroS2RslprlEr1pEksMvOfgwyQJLJLC/IHb3Z8zhxF7xDOOGV6xZwaGfTheMtgObaejiu1gAY5dXZP0ScCtmWtYoS4zKXIocloL4BtM6XvW6Y+PkcT8OUJpUda3mUgcww+FFIi7lQJMu8JTTQ5RoR8UeQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR12MB1355.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(396003)(346002)(39860400002)(376002)(2906002)(956004)(36756003)(66556008)(54906003)(86362001)(966005)(2616005)(6666004)(6916009)(478600001)(8676002)(66476007)(316002)(83380400001)(52116002)(6486002)(7696005)(8936002)(66946007)(5660300002)(186003)(4326008)(16526019)(26005)(136400200001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: +1QhCXQvGyK9o5bhyfsegjnu1pg9tT8sntqmnzctsBmt4Q4Tb8k0rmUBVmuE4SRMfek5KBlKxgrBOjReaWgOwbwOhZEK+GLexOnJXCgYBAY6pD5zIJDraRfSiJCEmiys5jTltqb4IzRl4KJK97p/wrweZvotgZzeHH6nexCfU60o2JCOWp9qXivM5u3undrbFWhWQgEuO1L02X1XZmRLrRo1pdqfNizkFGV3BJln3O75FPnncGx1WhKFXD+ZQE2rsPMysTyzaLjFUOQVtvx4B96TQqMo3YTd27MDxtB6/niJPsPi7+R+XyQ13SPWYa0CpNyEbwbk5zj2xSpeKYnkv6I2+rk6HDoJ6uD4sp8bPLC7+e1c+YdxK0i/rfDMBKF+bIm315W9rRSLKpB3cBVjlYWxAmnURDZJP+2i+g6hGtMENYG6i4HhS1B3mkgCCqDoylUse8VGRnPlR/PqA+O+42svlqaLsT2CR8UU2orDpPg/J77el4DpdcyvpUJ8CBYRrl3hS2HngULI5ANALvRsyF6kuX+FW8KozrJpzuYInzofgS77NLWqFgcAbOMCJUL/xPpLnOcEY9D8BDU4KR6BiGzhbGW/NoP7g1yNzxlf1hCT8TT0agDlOEyixGpX1j5sc/+iQmyx3L25+cXYp88Utg== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 44852d01-ce21-4dde-dd70-08d83f8cafbd X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1355.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Aug 2020 13:27:55.2231 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 55mMXcv6HHyyp4xkl7UkC6VnjhFvsx2Edbwg6UJkvCsizXQIpVpSdCZApxL795fO5w0tRjVBAwxWzUh+u975hA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4220 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2198 The SEV support will clear the C-bit from non-RAM areas. The early GDT lives in a non-RAM area, so when an exception occurs (like a #VC) the GDT will be read as un-encrypted even though it is encrypted. This will result in a failure to be able to handle the exception. Move the GDT into RAM so it can be accessed without error when running as an SEV-ES guest. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Reviewed-by: Laszlo Ersek Signed-off-by: Tom Lendacky --- OvmfPkg/PlatformPei/AmdSev.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/OvmfPkg/PlatformPei/AmdSev.c b/OvmfPkg/PlatformPei/AmdSev.c index 4fd4534cabea..a2b38c591236 100644 --- a/OvmfPkg/PlatformPei/AmdSev.c +++ b/OvmfPkg/PlatformPei/AmdSev.c @@ -39,6 +39,8 @@ AmdSevEsInitialize ( PHYSICAL_ADDRESS GhcbBasePa; UINTN GhcbPageCount, PageCount; RETURN_STATUS PcdStatus, DecryptStatus; + IA32_DESCRIPTOR Gdtr; + VOID *Gdt; =20 if (!MemEncryptSevEsIsEnabled ()) { return; @@ -83,6 +85,22 @@ AmdSevEsInitialize ( (UINT64)GhcbPageCount, GhcbBase)); =20 AsmWriteMsr64 (MSR_SEV_ES_GHCB, GhcbBasePa); + + // + // The SEV support will clear the C-bit from non-RAM areas. The early G= DT + // lives in a non-RAM area, so when an exception occurs (like a #VC) the= GDT + // will be read as un-encrypted even though it was created before the C-= bit + // was cleared (encrypted). This will result in a failure to be able to + // handle the exception. + // + AsmReadGdtr (&Gdtr); + + Gdt =3D AllocatePages (EFI_SIZE_TO_PAGES ((UINTN) Gdtr.Limit + 1)); + ASSERT (Gdt !=3D NULL); + + CopyMem (Gdt, (VOID *) Gdtr.Base, Gdtr.Limit + 1); + Gdtr.Base =3D (UINTN) Gdt; + AsmWriteGdtr (&Gdtr); } =20 /** --=20 2.28.0