public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: "Gao, Liming" <liming.gao@intel.com>,
	Leif Lindholm <leif.lindholm@linaro.org>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Feng, Bob C" <bob.c.feng@intel.com>
Subject: Re: [PATCH] BaseTools/Conf/gitattributes: fix "--function-context" for *.h and *.c
Date: Fri, 17 Jan 2020 09:24:35 +0100	[thread overview]
Message-ID: <ba06f1d5-1f60-f794-bc7e-add4095d9ed1@redhat.com> (raw)
In-Reply-To: <428016653b214ab699ec2d6b4ecf2fc9@intel.com>

On 01/17/20 01:22, Gao, Liming wrote:
> Leif:
>   Vfr is not C style source file. It can't be regarded as C source
>   file.
>
> Laszlo:
>    Is there such support for the assembly file, such as .nasm?

According to the gitattributes(5) manual, there doesn't seem to be a
git-diff driver for assembly files.

However, the default (language-independent) driver seems to handle it
reasonably well. Consider commit f4c898f2b2db
("UefiCpuPkg/CpuExceptionHandlerLib: Fix split lock", 2019-09-20).

$ git show f4c898f2b2db

this displays just the changes, with 3 lines of context, but it already
correctly displays the "HasErrorCode" label in the hunk header:

@@ -184,17 +184,19 @@ HasErrorCode:

Now, if I add "-W":

$ git show -W f4c898f2b2db

then the full text is displayed between "HasErrorCode" and "ErrorCode".

(You can see the entire file with:

$ git show f4c898f2b2db:UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ExceptionHandlerAsm.nasm

)

Thanks
Laszlo


      parent reply	other threads:[~2020-01-17  8:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-16 18:49 [PATCH] BaseTools/Conf/gitattributes: fix "--function-context" for *.h and *.c Laszlo Ersek
2020-01-16 21:54 ` Leif Lindholm
2020-01-17  0:22   ` Liming Gao
2020-01-17  0:51     ` Leif Lindholm
2020-01-17  0:56       ` Liming Gao
2020-01-17  8:30         ` Laszlo Ersek
2020-01-17 13:05           ` Leif Lindholm
2020-01-17 18:09             ` Laszlo Ersek
2020-01-17 19:37               ` Leif Lindholm
2020-01-19  1:47                 ` Liming Gao
2020-01-17  8:24     ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba06f1d5-1f60-f794-bc7e-add4095d9ed1@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox