From: "Stefan Berger" <stefanb@linux.ibm.com>
To: devel@edk2.groups.io, jiewen.yao@intel.com,
Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: "mhaeuser@posteo.de" <mhaeuser@posteo.de>,
"spbrogan@outlook.com" <spbrogan@outlook.com>,
"marcandre.lureau@redhat.com" <marcandre.lureau@redhat.com>,
"kraxel@redhat.com" <kraxel@redhat.com>
Subject: Re: [edk2-devel] [PATCH v5 0/8] Ovmf: Disable the TPM2 platform hierarchy
Date: Wed, 8 Sep 2021 08:53:57 -0400 [thread overview]
Message-ID: <ba185ce5-6a35-be00-4605-2878b7659283@linux.ibm.com> (raw)
In-Reply-To: <PH0PR11MB4885BF0F661DE0DD746ABBD58CD29@PH0PR11MB4885.namprd11.prod.outlook.com>
On 9/6/21 8:34 AM, Yao, Jiewen wrote:
>
> 2) I am curious, why you don't use a DXE driver, but choose to like to BDS lib for the DXE case.
> You also include a NULL lib there, which seems unnecessary, if you use a DXE/PEI module.
>
> The downside of linking to BDS lib is that you have to change all BDS lib instance, which is a big burden.
> And you still have code to choose NULL lib v.s. real Lib based upon TPM enable flag.
We have to call ConfigureTpmPlatformHierarchy () some time *after* the
handling of physical presence interface (PPI) platform opcodes since the
TPM 2 commands they produce may require access to the TPM 2's platform
hierarchy, so we cannot disable that hierarchy before handling PPI. For
x86 machines I found the call to handling the PPI opcodes in different
files and placed that call right after it. On ARM it's a bit different.
Here it's the fact that I placed that call into the same function
PlatformBootManagerAfterConsole as it is on x86. This seemed a safe place.
Stefan
next prev parent reply other threads:[~2021-09-08 12:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 21:21 [PATCH v5 0/8] Ovmf: Disable the TPM2 platform hierarchy Stefan Berger
2021-09-01 21:21 ` [PATCH v5 1/8] SecurityPkg/TPM: Import PeiDxeTpmPlatformHierarchyLib.c from edk2-platforms Stefan Berger
2021-09-01 21:21 ` [PATCH v5 2/8] SecurityPkg/TPM: Fix bugs in imported PeiDxeTpmPlatformHierarchyLib Stefan Berger
2021-09-01 21:21 ` [PATCH v5 3/8] SecurityPkg/TPM: Add a NULL implementation of TpmPlatformHierarchyLib Stefan Berger
2021-09-01 21:21 ` [PATCH v5 4/8] SecurityPkg: Introduce new PCD PcdRandomizePlatformHierarchy Stefan Berger
2021-09-01 21:21 ` [PATCH v5 5/8] OvmfPkg: Reference new TPM classes in the build system for compilation Stefan Berger
2021-09-01 21:21 ` [PATCH v5 6/8] OvmfPkg: Disable the TPM2 platform hierarchy Stefan Berger
2021-09-01 21:21 ` [PATCH v5 7/8] ArmVirtPkg: Reference new TPM classes in the build system for compilation Stefan Berger
2021-09-01 21:21 ` [PATCH v5 8/8] ArmVirtPkg: Disable the TPM2 platform hierarchy Stefan Berger
2021-09-02 1:27 ` [edk2-devel] [PATCH v5 0/8] Ovmf: " Stefan Berger
2021-09-06 12:34 ` Yao, Jiewen
2021-09-06 13:50 ` [edk2-devel] " Stefan Berger
2021-09-06 15:05 ` Yao, Jiewen
[not found] ` <16A243F1DBDE42C8.5578@groups.io>
2021-09-06 15:07 ` Yao, Jiewen
2021-09-07 19:41 ` Stefan Berger
2021-09-07 19:44 ` Stefan Berger
2021-09-08 12:53 ` Stefan Berger [this message]
2021-09-08 14:37 ` Yao, Jiewen
2021-09-08 20:34 ` Stefan Berger
2021-09-09 0:19 ` Yao, Jiewen
2021-09-09 11:13 ` Stefan Berger
2021-09-09 11:37 ` Gerd Hoffmann
2021-09-09 16:15 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba185ce5-6a35-be00-4605-2878b7659283@linux.ibm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox