From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.groups.io with SMTP id smtpd.web10.591.1570728511805566952 for ; Thu, 10 Oct 2019 10:28:32 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=1ron4zWC; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.128.65, mailfrom: pete@akeo.ie) Received: by mail-wm1-f65.google.com with SMTP id m18so7634832wmc.1 for ; Thu, 10 Oct 2019 10:28:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=okA1JZ8lsH9gHUxIeVgm2pBJRIKb5XBHuQfO191eBi4=; b=1ron4zWCgXqnjV4CpoyLAac4m8LQF7fIFT5IWdbBGvnb/g/5wbDdOZh9PxhFLnJvrq 67bCaHH3bwD//0wiRtr2mlbtwwQa+f43ry83w35+35XjxtMIRy1OwSgHj5rrN4bFrXFv HUELAyjF2lMiUUgyMJW1ynLc6rF3FfA5/WGrRpLKhPz9e3Kc+Pg6GbdEEexHdRMyqope lxfn0e89Q1nryFUrMYqsyggqogpNjKybb+8/Ii6BjfiQchZMHkZDasj2xE7Oj4k/QcUq eFgE4irfhSlWFFKudWXjfh0oqr9Rz5DupmSFcQq9S6bH08wJcq6JpwxFanUY9aKarvd3 0YBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=okA1JZ8lsH9gHUxIeVgm2pBJRIKb5XBHuQfO191eBi4=; b=RldmRwclrl9ILRqhIz+Cn508g/yieca7PMTfOnQgyjLC1HzvmZUfCAn8GWQgExlAtm aMmBRXOi9H59gKAnEc7TR04kPEWNrUVK+k6YLtawAnlVT8uHVh5jCW82BapefcHe3zPQ jYqAhv2o847RWOw3zJBfxCwtAvX4hJcmoVAcFC1loIzNQP+CyD3E3Ct2SIFNjyzei9Xu QwSqDd7YZTC/AG+/d2JyVthRVrQ6cypPWCfP/LyUROehEjQLGG1Wnd433x2njpvOdSgt z0QfZ3jpFK3N1+ZMVL82QgaJBOQ1f4c2WBZm+0bbBoETTC22nAy9p6bVIWHABSIGg7s0 pimA== X-Gm-Message-State: APjAAAWYOllBeRpCJXheLLHUeaU12k5PSqIVR63hUoOOIW5SBlxZnZ1Z dAM0ZT+SaS/8xh/6aqkhCdSFIg== X-Google-Smtp-Source: APXvYqz63Njm9c73pRfKTyS6hZ4a5R5PvKR1dw9Xgu3JM37EmiErU7uqjnbFPCs3EMpvslfN5VlTHA== X-Received: by 2002:a7b:c395:: with SMTP id s21mr8454581wmj.102.1570728510350; Thu, 10 Oct 2019 10:28:30 -0700 (PDT) Return-Path: Received: from [10.0.0.122] ([84.203.40.122]) by smtp.googlemail.com with ESMTPSA id g11sm7175374wmh.45.2019.10.10.10.28.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Oct 2019 10:28:29 -0700 (PDT) Subject: Re: [edk2-platforms][PATCH v2 2/5] Platform/RPi3/RpiFirmwareDxe: Improve serial number population To: Leif Lindholm Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org References: <20191008123841.12952-1-pete@akeo.ie> <20191008123841.12952-3-pete@akeo.ie> <20191010084344.GT25504@bivouac.eciton.net> <766e6b6f-d788-e46e-e58f-84a2f851645c@akeo.ie> <20191010164900.GP25504@bivouac.eciton.net> From: "Pete Batard" Message-ID: Date: Thu, 10 Oct 2019 18:28:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191010164900.GP25504@bivouac.eciton.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 2019.10.10 17:49, Leif Lindholm wrote: > On Thu, Oct 10, 2019 at 01:41:20PM +0100, Pete Batard wrote: >> It's a disagreement. And the same goes for 3/5 & 4/5. Please see the note I >> wrote in 0/5 for the v2, because the cover letter this is usually the place >> I try to clarify elements that may throw off a maintainer, and that don't >> belong in a commit message. >> >> Not so sound flippant here, but as long as there isn't an MTV award for >> "Most atomic codebase ever", I just don't have the time to split what I >> consider to be frivolous commits. The reasoning behind that is that I >> realistically don't consider that people are actually going to be thrown off >> by a "while I was here I also fixed an obvious typo" that got added into an >> existing commit or, most important, that even if they do, the amount of time >> that is going to be collectively wasted by people who might be thrown of by >> not having uber atomicity is not going to exceed the amount of time it will >> cost *me* to split it. >> >> Therefore, while I do understand the desire to have an atomic commit >> history, I'm afraid that if we can't strike a balance between how much extra >> time contributors are expected to waste vs how atomic a *real-life* >> codebase is enforced to be, if I have to split every little typo and >> stylistic fix into yet another commit, I'm simply not going to bother fixing >> typos or low hanging fruits I see any more. > > I understand, we all have a limited supply of time. > > Since I don't wish to start implementing different rules for different > contributors, could I ask you to stop contributing typo and low > hanging fruit fixes? I'm fine with that. Regards, /Pete > > Best Regards, > > Leif >