Re: [PATCH v5 0/7] Introduce two public functions and remove internal ones

["Ni, Ruiyu" <ruiyu.ni@Intel.com>]

On 1/30/2019 2:34 PM, Shenglei Zhang wrote:
> Introduce public functions CharToUpper and AsciiCharToUpper.
> Remove internal functions InternalCharToUpper and InternalBaseLibAsciiToUpper.
> 
> v2: Update the title and commit message of 1/3.
> 
> v3: 1.Add a patch to remove AsciiToUpper in EdbSupportString.c.
>      2.Revert the changes in Basetools.
> 
> v4: 1.Add1/7: Change function names in EdbSupportString.c.
>      2.Update the title of 4/7.
>      3.Add 5/7: Use BaseLib api AsciiToUpper in DxeHttpLib.c.
>      4.Add 6/7: Use BaseLib api CharToUpper in ShellManParser.c.
>      5.Add 7/7: Use BaseLib api CharToUpper in UefiShellLib.c.
> 
> v5: Change AsciiToUpper to AsciiCharToUpper in 2/7,4/7 and 5/7.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Shenglei Zhang (7):
>    MdeModulePkg/EbcDebugger: Change function names
>    MdePkg/BaseLib: Introduce CharToUpper and AsciiCharToUpper publicly
>    MdePkg/BaseLib: Remove definitions of two functions
>    MdeModulePkg/EbcDebugger: Use AsciiCharToUpper and CharToUpper
>    MdeModulePkg/DxeHttpLib: Use BaseLib api AsciiCharToUpper
>    ShellPkg/Shell: Use BaseLib api CharToUpper
>    ShellPkg/UefiShellLib: Use BaseLib api CharToUpper
> 
>   MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c  | 23 +---------
>   .../EbcDxe/EbcDebugger/EdbSupportString.c     | 39 ++---------------
>   MdePkg/Include/Library/BaseLib.h              | 40 ++++++++++++++++++
>   MdePkg/Library/BaseLib/BaseLibInternals.h     | 42 -------------------
>   MdePkg/Library/BaseLib/SafeString.c           |  8 ++--
>   MdePkg/Library/BaseLib/String.c               | 16 +++----
>   ShellPkg/Application/Shell/ShellManParser.c   | 23 +---------
>   ShellPkg/Library/UefiShellLib/UefiShellLib.c  | 31 +-------------
>   8 files changed, 60 insertions(+), 162 deletions(-)
> 
Reviewed-by: Ray Ni <ray.ni@intel.com>

-- 
Thanks,
Ray