From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 10C37211BFCC6 for ; Wed, 30 Jan 2019 01:34:16 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2019 01:34:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,540,1539673200"; d="scan'208";a="271095049" Received: from ray-dev.ccr.corp.intel.com (HELO [10.239.9.31]) ([10.239.9.31]) by orsmga004.jf.intel.com with ESMTP; 30 Jan 2019 01:34:14 -0800 To: Shenglei Zhang , edk2-devel@lists.01.org Cc: Michael D Kinney , Liming Gao , Jian J Wang , Hao Wu , Star Zeng , Jaben Carsey References: <20190130063417.11308-1-shenglei.zhang@intel.com> From: "Ni, Ruiyu" Message-ID: Date: Wed, 30 Jan 2019 17:36:37 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190130063417.11308-1-shenglei.zhang@intel.com> Subject: Re: [PATCH v5 0/7] Introduce two public functions and remove internal ones X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 09:34:17 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 1/30/2019 2:34 PM, Shenglei Zhang wrote: > Introduce public functions CharToUpper and AsciiCharToUpper. > Remove internal functions InternalCharToUpper and InternalBaseLibAsciiToUpper. > > v2: Update the title and commit message of 1/3. > > v3: 1.Add a patch to remove AsciiToUpper in EdbSupportString.c. > 2.Revert the changes in Basetools. > > v4: 1.Add1/7: Change function names in EdbSupportString.c. > 2.Update the title of 4/7. > 3.Add 5/7: Use BaseLib api AsciiToUpper in DxeHttpLib.c. > 4.Add 6/7: Use BaseLib api CharToUpper in ShellManParser.c. > 5.Add 7/7: Use BaseLib api CharToUpper in UefiShellLib.c. > > v5: Change AsciiToUpper to AsciiCharToUpper in 2/7,4/7 and 5/7. > > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Jian J Wang > Cc: Hao Wu > Cc: Star Zeng > Cc: Ruiyu Ni > Cc: Jaben Carsey > Shenglei Zhang (7): > MdeModulePkg/EbcDebugger: Change function names > MdePkg/BaseLib: Introduce CharToUpper and AsciiCharToUpper publicly > MdePkg/BaseLib: Remove definitions of two functions > MdeModulePkg/EbcDebugger: Use AsciiCharToUpper and CharToUpper > MdeModulePkg/DxeHttpLib: Use BaseLib api AsciiCharToUpper > ShellPkg/Shell: Use BaseLib api CharToUpper > ShellPkg/UefiShellLib: Use BaseLib api CharToUpper > > MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c | 23 +--------- > .../EbcDxe/EbcDebugger/EdbSupportString.c | 39 ++--------------- > MdePkg/Include/Library/BaseLib.h | 40 ++++++++++++++++++ > MdePkg/Library/BaseLib/BaseLibInternals.h | 42 ------------------- > MdePkg/Library/BaseLib/SafeString.c | 8 ++-- > MdePkg/Library/BaseLib/String.c | 16 +++---- > ShellPkg/Application/Shell/ShellManParser.c | 23 +--------- > ShellPkg/Library/UefiShellLib/UefiShellLib.c | 31 +------------- > 8 files changed, 60 insertions(+), 162 deletions(-) > Reviewed-by: Ray Ni -- Thanks, Ray