From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id A9323941381 for ; Mon, 22 Apr 2024 08:40:28 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=iRsI7y1pn69g2YJUVHp+ztNYE0dzqOEnHvt1zMK19z4=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20240206; t=1713775227; v=1; b=L+3choVlqwHrdX3+Jwq/x0Vy4LCwzW0MvwhdlJL1M5iWOsMbJGlhC1wM6ugXeKebXrVbFy01 UrELZQBPXqRFNWMJBuFHjFBy7yifhb5+olBl5cUvwMKzxu0PBcXjnONZyH7rLRyi4VVggPRQFMY XwJUyX1lXDGyKQkDwLF82Dy9TTuHJ1EDOGgZcVyW4ndf1cw8nVx9DIsMXAZyH9fKD0XnGbL4tUG xqd35ZCx1Mi7whAVPub6hNYuUIB5L2GvBuvqrlkbsQtFmeo4A0StWmU25OJ1clOCgQA8BEgTMqE T0SXMoSJqYEEovz8EKIJWc9GC9mm49WT8WEWgSqFVGfdg== X-Received: by 127.0.0.2 with SMTP id u7LGYY7687511xIbbi39Ox2I; Mon, 22 Apr 2024 01:40:27 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by mx.groups.io with SMTP id smtpd.web11.13599.1713775221784780073 for ; Mon, 22 Apr 2024 01:40:21 -0700 X-CSE-ConnectionGUID: PdvfxiARSm6D/TlqdbIagw== X-CSE-MsgGUID: 7LvAvhbuTECTvlFjet3Zww== X-IronPort-AV: E=McAfee;i="6600,9927,11051"; a="26821121" X-IronPort-AV: E=Sophos;i="6.07,220,1708416000"; d="scan'208";a="26821121" X-Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2024 01:40:21 -0700 X-CSE-ConnectionGUID: 0oaDZuCmT9+Q+PJQZZJsNg== X-CSE-MsgGUID: 4BFOGoM/QIiHvpCpaj+d1g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,220,1708416000"; d="scan'208";a="28718068" X-Received: from chsuehx-desk.gar.corp.intel.com ([10.225.77.6]) by orviesa005.jf.intel.com with ESMTP; 22 Apr 2024 01:40:19 -0700 From: dorax.hsueh@intel.com To: devel@edk2.groups.io Cc: DoraX Hsueh , Sai Chaganty , Rosen Chuang , Saloni Kasbekar , Haoyu Tang , Nate DeSimone , Chasel Chiu Subject: [edk2-devel] [PATCH] AlderlakeOpenBoardPkg: Halt the TCO timer. Date: Mon, 22 Apr 2024 16:40:06 +0800 Message-Id: MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 22 Apr 2024 01:40:21 -0700 Resent-From: dorax.hsueh@intel.com Reply-To: devel@edk2.groups.io,dorax.hsueh@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: nPYbdlkKBjHLCCbTIOX1NjXix7686176AA= Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=L+3choVl; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io From: DoraX Hsueh https://bugzilla.tianocore.org/show_bug.cgi?id=3D4761 Halt the TCO timer to fix release mode hang. Cc: Sai Chaganty Cc: Rosen Chuang Cc: Saloni Kasbekar Cc: Haoyu Tang Cc: Nate DeSimone Cc: Chasel Chiu Signed-off-by: DoraX Hsueh --- .../AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoardPkg.dsc | 3 ++- .../Library/SecFspWrapperPlatformSecLib/PlatformInit.c | 8 ++++++++ .../SecFspWrapperPlatformSecLib.inf | 1 + 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoardPk= g.dsc b/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoardPkg.dsc index 59350f06..ea92ec75 100644 --- a/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoardPkg.dsc +++ b/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoardPkg.dsc @@ -233,8 +233,9 @@ =0D [LibraryClasses.X64.DXE_SMM_DRIVER]=0D =0D -!if $(TARGET) =3D=3D DEBUG=0D SpiFlashCommonLib|IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiFla= shCommonLib.inf=0D +=0D +!if $(TARGET) =3D=3D DEBUG=0D TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLib/Smm= TestPointCheckLib.inf=0D TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLibNull= /TestPointCheckLibNull.inf=0D !endif=0D diff --git a/Platform/Intel/AlderlakeOpenBoardPkg/FspWrapper/Library/SecFsp= WrapperPlatformSecLib/PlatformInit.c b/Platform/Intel/AlderlakeOpenBoardPkg= /FspWrapper/Library/SecFspWrapperPlatformSecLib/PlatformInit.c index f7ec4f9e..e930c9c7 100644 --- a/Platform/Intel/AlderlakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper= PlatformSecLib/PlatformInit.c +++ b/Platform/Intel/AlderlakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper= PlatformSecLib/PlatformInit.c @@ -12,6 +12,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include =0D #include =0D #include =0D +#include =0D +#include =0D =0D /**=0D Platform initialization.=0D @@ -28,6 +30,12 @@ PlatformInit ( IN VOID *EndOfRange=0D )=0D {=0D +=0D + ///=0D + /// Halt the TCO timer as early as possible=0D + ///=0D + IoWrite16 (PcdGet16 (PcdTcoBaseAddress) + R_TCO_IO_TCO1_CNT, B_TCO_IO_TC= O1_CNT_TMR_HLT);=0D +=0D //=0D // Platform initialization=0D // Enable Serial port here=0D diff --git a/Platform/Intel/AlderlakeOpenBoardPkg/FspWrapper/Library/SecFsp= WrapperPlatformSecLib/SecFspWrapperPlatformSecLib.inf b/Platform/Intel/Alde= rlakeOpenBoardPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/SecFspWrap= perPlatformSecLib.inf index 3e51cb36..abc84057 100644 --- a/Platform/Intel/AlderlakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper= PlatformSecLib/SecFspWrapperPlatformSecLib.inf +++ b/Platform/Intel/AlderlakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper= PlatformSecLib/SecFspWrapperPlatformSecLib.inf @@ -89,6 +89,7 @@ gIntelFsp2WrapperTokenSpaceGuid.PcdFsptBaseAddress ## C= ONSUMES=0D gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize ## C= ONSUMES=0D gMinPlatformPkgTokenSpaceGuid.PcdSecSerialPortDebugEnable ## C= ONSUMES=0D + gSiPkgTokenSpaceGuid.PcdTcoBaseAddress ## C= ONSUMES=0D =0D [FixedPcd]=0D gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeBase ## C= ONSUMES=0D --=20 2.26.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118077): https://edk2.groups.io/g/devel/message/118077 Mute This Topic: https://groups.io/mt/105665490/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-