public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Irene Park" <ipark@nvidia.com>
To: <devel@edk2.groups.io>, <bob.c.feng@intel.com>,
	<gaoliming@byosoft.com.cn>
Cc: Irene Park <ipark@nvidia.com>
Subject: [PATCH] BaseTools: Fix the improper error logging
Date: Mon, 28 Dec 2020 20:46:54 -0500	[thread overview]
Message-ID: <ba5c63d5c4d379bfcb2d3d34f257a6e48b2fc6b9.1609205485.git.ipark@nvidia.com> (raw)

From: Irene Park <ipark@nvidia.com>

EdkLogger.ERROR() was replaced with EdkLogger.error() to deliver the
expected error message when an error occurs.

Signed-off-by: Irene Park <ipark@nvidia.com>

---
 BaseTools/Source/Python/AutoGen/GenPcdDb.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Source/Python/AutoGen/GenPcdDb.py b/BaseTools/Source/Python/AutoGen/GenPcdDb.py
index 0870c44..ad5dae0 100644
--- a/BaseTools/Source/Python/AutoGen/GenPcdDb.py
+++ b/BaseTools/Source/Python/AutoGen/GenPcdDb.py
@@ -894,7 +894,7 @@ def CreatePcdDataBase(PcdDBData):
     delta = {}
     for skuname, skuid in PcdDBData:
         if len(PcdDBData[(skuname, skuid)][1]) != len(PcdDBData[(TAB_DEFAULT, "0")][1]):
-            EdkLogger.ERROR("The size of each sku in one pcd are not same")
+            EdkLogger.error("build", AUTOGEN_ERROR, "The size of each sku in one pcd are not same")
     for skuname, skuid in PcdDBData:
         if skuname == TAB_DEFAULT:
             continue
-- 
2.7.4


             reply	other threads:[~2020-12-29  1:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-29  1:46 Irene Park [this message]
2021-01-04  1:01 ` 回复: [PATCH] BaseTools: Fix the improper error logging gaoliming
2021-01-04  2:32 ` [edk2-devel] " Bob Feng
     [not found] ` <1656E6B2AE248774.11073@groups.io>
2021-01-06  1:49   ` Bob Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba5c63d5c4d379bfcb2d3d34f257a6e48b2fc6b9.1609205485.git.ipark@nvidia.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox