From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by mx.groups.io with SMTP id smtpd.web08.6640.1609206426041635751 for ; Mon, 28 Dec 2020 17:47:06 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=n1 header.b=cvsKddMY; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 216.228.121.64, mailfrom: ipark@nvidia.com) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Mon, 28 Dec 2020 17:47:05 -0800 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 29 Dec 2020 01:47:04 +0000 Received: from ipark-ubuntu.nvidia.com (172.20.145.6) by mail.nvidia.com (172.20.187.15) with Microsoft SMTP Server id 15.0.1473.3 via Frontend Transport; Tue, 29 Dec 2020 01:47:03 +0000 From: "Irene Park" To: , , CC: Irene Park Subject: [PATCH] BaseTools: Fix the improper error logging Date: Mon, 28 Dec 2020 20:46:54 -0500 Message-ID: X-Mailer: git-send-email 2.7.4 X-NVConfidentiality: public Return-Path: ipark@nvidia.com MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1609206425; bh=8Tvb7K6ysWcFAL5SEhVNp+RE8fLbuG6bFJSGuQTDDfA=; h=From:To:CC:Subject:Date:Message-ID:X-Mailer:X-NVConfidentiality: MIME-Version:Content-Type; b=cvsKddMYZaVSmX5MmoWxR+YaZTQ5V9KEXfhlDBguOPXByATOtAZ5Cvjg4wZO87A+5 BECWxOCWvao3+y2AmzSLyYa/bV93uR8sXvPVoVy8yINmYh0e/hmgzYULNgtk43F804 dytd/99la+t61o3+p7LboPIr9pHrhow5rkhhZxJ7cQE07F6sW39p0IXCQApBaFRm7V tyrXCv++RE1XfCQS1Ku1iujA4jPPBVbkHqzPGeXD6FYeZnXItHSU3/oyvp3C9WGSv8 f8prukLLuIIngr2oAcJVmKiavBDMystnGpBh3jboDx6UWHIA5R/Neao6+U8UPsLear oapwFXnGpkabw== Content-Type: text/plain From: Irene Park EdkLogger.ERROR() was replaced with EdkLogger.error() to deliver the expected error message when an error occurs. Signed-off-by: Irene Park --- BaseTools/Source/Python/AutoGen/GenPcdDb.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/AutoGen/GenPcdDb.py b/BaseTools/Source/Python/AutoGen/GenPcdDb.py index 0870c44..ad5dae0 100644 --- a/BaseTools/Source/Python/AutoGen/GenPcdDb.py +++ b/BaseTools/Source/Python/AutoGen/GenPcdDb.py @@ -894,7 +894,7 @@ def CreatePcdDataBase(PcdDBData): delta = {} for skuname, skuid in PcdDBData: if len(PcdDBData[(skuname, skuid)][1]) != len(PcdDBData[(TAB_DEFAULT, "0")][1]): - EdkLogger.ERROR("The size of each sku in one pcd are not same") + EdkLogger.error("build", AUTOGEN_ERROR, "The size of each sku in one pcd are not same") for skuname, skuid in PcdDBData: if skuname == TAB_DEFAULT: continue -- 2.7.4