Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/RaspberryPi: Switch to MbedTls crypto library

["Jeremy Linton" <jeremy.linton@arm.com>]

Hi,

On 8/30/24 3:18 AM, Ard Biesheuvel wrote:
> From: Ard Biesheuvel <ardb@kernel.org>
> 
> Switch to the MbedTls crypto library, which uses less space, which has
> run out on RPi4 (the DEBUG build can only succeed with HTTPS boot
> disabled at this point)

This is going to be endless, maybe its better to adjust the image 
offsets to increase the space available, its not like we have a problem 
with storage capacity. The only gotcha with the patch I pointed out a 
few months ago was that it requires moving the DTB in the config.txt 
file as well, along with TFA. I was looking at alternatives, IIRC its 
possible to gain some space without doing that just by moving a few 
things around.



> 
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
>   Platform/RaspberryPi/RPi3/RPi3.dsc | 5 +++--
>   Platform/RaspberryPi/RPi4/RPi4.dsc | 5 +++--
>   2 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc
> index 43d6d028e126..86c5281d7af6 100644
> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc
> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
> @@ -134,7 +134,8 @@ [LibraryClasses.common]
>     # Cryptographic libraries
>     RngLib|MdePkg/Library/DxeRngLib/DxeRngLib.inf
>     IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
> -  BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
> +  BaseCryptLib|CryptoPkg/Library/BaseCryptLibMbedTls/BaseCryptLib.inf
> +  MbedTlsLib|CryptoPkg/Library/MbedTlsLib/MbedTlsLib.inf
>     OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
>     TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
>   
> @@ -228,7 +229,7 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER]
>     VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf
>   
>   !if $(SECURE_BOOT_ENABLE) == TRUE
> -  BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
> +  BaseCryptLib|CryptoPkg/Library/BaseCryptLibMbedTls/RuntimeCryptLib.inf
>   !endif
>   
>   ###################################################################################################
> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
> index c79f322d9e75..2e7798c71ff3 100644
> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
> @@ -134,7 +134,8 @@ [LibraryClasses.common]
>     # Cryptographic libraries
>     RngLib|MdePkg/Library/DxeRngLib/DxeRngLib.inf
>     IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
> -  BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
> +  BaseCryptLib|CryptoPkg/Library/BaseCryptLibMbedTls/BaseCryptLib.inf
> +  MbedTlsLib|CryptoPkg/Library/MbedTlsLib/MbedTlsLib.inf
>     OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
>     TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
>   
> @@ -236,7 +237,7 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER]
>     VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf
>   
>   !if $(SECURE_BOOT_ENABLE) == TRUE
> -  BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
> +  BaseCryptLib|CryptoPkg/Library/BaseCryptLibMbedTls/RuntimeCryptLib.inf
>   !endif
>   
>   ###################################################################################################



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120454): https://edk2.groups.io/g/devel/message/120454
Mute This Topic: https://groups.io/mt/108184374/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-