From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (EUR01-VE1-obe.outbound.protection.outlook.com [40.107.14.72]) by mx.groups.io with SMTP id smtpd.web09.2280.1621369546005092182 for ; Tue, 18 May 2021 13:25:46 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=xw8oE7SB; spf=pass (domain: arm.com, ip: 40.107.14.72, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lmowGDaD8fwn3wHnEOrbNqseMZFbT5qc3AakF0jxDUI=; b=xw8oE7SB3nJOruzfgEgGldXaG55o6B9NqNTpYYBMXYCUAWu5MKR5VOg8Z3rWWgRsf0aC0I8JYJQJnQwEsH8TFjslzt8qxxTrgZ2lFjUbS9Etbe7iE/PerUM5KxMaRC2uwjRndIlUiEcsXmm+G+KJ77YGNb7Cu+dPlnjYE9wWD4s= Received: from AM6P195CA0066.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:87::43) by AM0PR08MB4195.eurprd08.prod.outlook.com (2603:10a6:208:131::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.26; Tue, 18 May 2021 20:25:41 +0000 Received: from VE1EUR03FT047.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:87:cafe::c4) by AM6P195CA0066.outlook.office365.com (2603:10a6:209:87::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Tue, 18 May 2021 20:25:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT047.mail.protection.outlook.com (10.152.19.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25 via Frontend Transport; Tue, 18 May 2021 20:25:41 +0000 Received: ("Tessian outbound 3c5232d12880:v92"); Tue, 18 May 2021 20:25:40 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 7d5b69a9e1092fd5 X-CR-MTA-TID: 64aa7808 Received: from 90dc8d688878.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A5658DAC-1FDF-4E6F-8DDB-FA73165EA34B.1; Tue, 18 May 2021 20:25:35 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 90dc8d688878.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 18 May 2021 20:25:35 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aT75Uau8GGPJFsWeGcEKIO94FlkCDmYRR8LHvAbAyp1ZEpM2IUXx5Mg/LTQ8LlpRNx7KNPOiNIiwuojKPl1xlruFjW9gnl0JMmkmg4ajL4GXcSQu8cg7zfWQQecSk/COr5R5tlWWp4/E25y2QvalS4DB5n4cTIw30nQS8lxYXhmbEWm0DmGtAq+LABeaavrg33DMZFYLkQ+JVqfDSBkMFyvq4UtkwMZowhgmI3fReGf1Gz4xjwhwvMe/PsHlPxUkaNU3+yXKv9X4nbfYVSS8gTY0EstCqsk0r+QLDCihmo7S6YZhnUY4WwY9xdCqbN3XypIH7mKiYGiVVrIINWHjXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lmowGDaD8fwn3wHnEOrbNqseMZFbT5qc3AakF0jxDUI=; b=DR7V3drRwX/8/HKPCXbpIPyPxzA5f/zEFsBgEe2lYlJsiqzslW5cjoRKcsOa6szxCps+r2QgpJNMPBSUotm5NPm1fOHjb5wtPc4pXxzjPg4HEjYMm93xVkjuq35qAMvFoygAbKX4JpUq4Pv2TipcdpQ/DCg6+paosStypJ4P11JpAQIOEjSoKfqBvOXha+nqI48cE/JKPNqiP+8TN4h1xynK7wR3nQ9SW5ftoJcXCIx3+sCD3AaR+Tfz7oSxFrjVv73n0/P++FF5tAK+fKiIHnB33RDA/BBX+7Ltmpx2UNMartWO82PPpCOB2ljBpEhZfyqwuxuMaWIbhgOGiUvxDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lmowGDaD8fwn3wHnEOrbNqseMZFbT5qc3AakF0jxDUI=; b=xw8oE7SB3nJOruzfgEgGldXaG55o6B9NqNTpYYBMXYCUAWu5MKR5VOg8Z3rWWgRsf0aC0I8JYJQJnQwEsH8TFjslzt8qxxTrgZ2lFjUbS9Etbe7iE/PerUM5KxMaRC2uwjRndIlUiEcsXmm+G+KJ77YGNb7Cu+dPlnjYE9wWD4s= Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM6PR08MB4213.eurprd08.prod.outlook.com (2603:10a6:20b:8e::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.26; Tue, 18 May 2021 20:25:33 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::80cb:878d:c8f1:2688]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::80cb:878d:c8f1:2688%7]) with mapi id 15.20.4129.033; Tue, 18 May 2021 20:25:33 +0000 Subject: Re: [PATCH v2 2/5] MdeMoudlePkg: introduce new PCD for Acpi/rsdp To: Jianyong Wu , devel@edk2.groups.io, lersek@redhat.com, ardb+tianocore@kernel.org Cc: hao.a.wu@intel.com, justin.he@arm.com, Jian J Wang , nd@arm.com References: <20210517065032.82423-1-jianyong.wu@arm.com> <20210517065032.82423-3-jianyong.wu@arm.com> From: "Sami Mujawar" Message-ID: Date: Tue, 18 May 2021 21:25:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20210517065032.82423-3-jianyong.wu@arm.com> X-Originating-IP: [217.140.106.52] X-ClientProxiedBy: LO4P123CA0344.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18d::7) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.1.196.43] (217.140.106.52) by LO4P123CA0344.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25 via Frontend Transport; Tue, 18 May 2021 20:25:33 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f8104888-aaf2-418f-5726-08d91a3b1b6c X-MS-TrafficTypeDiagnostic: AM6PR08MB4213:|AM0PR08MB4195: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:5236;OLM:5236; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: or11JDqO5Xm7SjM14uAnp07HUzpPqAKmg9arezTlPZo16EIZl2/fxdWYhWduowbicoUEnprqqYQzLexK8wT6tqieu8ucMhMcGZQTBoqX0uwDZn8nCohaEsxEZup58HLHs5QP1nB4bMf5LfrhP/7OIFXT+94rB1+NfLP5+kqklG7UUqeNiRunxHNyfY689ckkHrLVutsIo4fH0wIqRhWOacfEb5c5G3swXE5t1z+ThcjLyhTqRuZ03TSt0NpfuvEMTn9XorJOs9PBzoqUmKHWIm6ccNQHEJMESm1xpIJsWd4z7bnAmGhz1VCDWCiZsVEpIj7t1a23b9DL/Y7daPTZg58MduK0CO0VbAAm0pq7Hf7s1MwA+wSLeO/6nOSnshVxcxQSH/CudTbDr+qjjKm0UVZwv0WM/ak1H31ABlqYdQqdL7UfaOKhqPuoUuY5TEL1RcoGH0kkPM9dByQqTGxN4PduaXe5EjojH5lDuG1jFaGmSbzIjkh4v9LpQCJ4CeSye3H+CpLbwFhfikst9rehjiWD8uHMMO4oQyiMTV2crj45VGMl/zXq8D3loTwC7EeYAjZrehAwFiLPkddhaBEdvdWjLxmg4YStuD9EvuiW3XFA3N3KFI3WIE5BRAQ4lQN1Cf1I/8djFIFpaOr7eERihWV86arXgl2CV9WProKdhNV7EPxNjQoC9LNaFrB7BYKxYRqb+zZjQ46C967BsMXCg2lCKV9YFCrMGVyYrdVHLXDR9wVuHGFpP+tgHl7xa/XE X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(346002)(376002)(136003)(396003)(39850400004)(66556008)(16576012)(316002)(66946007)(956004)(52116002)(44832011)(2616005)(36756003)(66476007)(53546011)(86362001)(5660300002)(38100700002)(6486002)(38350700002)(16526019)(26005)(2906002)(31686004)(31696002)(478600001)(8936002)(8676002)(186003)(4326008)(43740500002)(45980500001)(14943795004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ZFh4N2RoM3d5Z1AxUVYxQ1lRNTZMMVZpd0lMellGL29JUC9obWJmNVFwVVVK?= =?utf-8?B?QTNDRjNZTDdZSE1BOHhpZGVKUFltSzQ4YktLM2NiOGx6eGxTLzY4SEF6QlRN?= =?utf-8?B?RmU4WjRWUEN3MnVEL3lnMUttRUVCVk5VUE9nNmI3L3VTODhvaUtTRHYyYW1G?= =?utf-8?B?NGJybTl6c3FzejZpUTRvZUhndHZIZDZtR3AvRlQ0RkV0QjJCTkFrVkxRUnd6?= =?utf-8?B?TlR3amxGUmJhNTRmejJhWlp2NTM4V3JBM0JxQkJRMi9ST0krNzBkZnFZU1o2?= =?utf-8?B?UDRxZGxDV0lHYkxPRW5EZ2dKNDVoN25qZkJxSGhxbjJreW9tbWt1Q1Vic1oz?= =?utf-8?B?QzBDaGR5VlUzbjYvUGhBdTZBWXpXeFpKYXVpdlpkU2E5Q3FwbUtENXk5bDFo?= =?utf-8?B?cmJHNi90Mk1QZGtqZ0tUOVhKNXR4UllXME1KMmNSN3haWmtzS21KK3N5OFpn?= =?utf-8?B?UWFmdEZKVHhXV0hXSHFWT1ZXQ2FtNmRtd2h6RGE2Y0R6L2hYb1NOUUlJbkVl?= =?utf-8?B?bVEremxXWkRqKzFkSStlL081aDE0b2JUd0FlUUVUR1huVHd0WXU5ZjB1Y0pE?= =?utf-8?B?UG9lY21VRDFWVE9DckY5OFI1NlM4WDR6dEFub2ZIWFg4Rmh3d1ZkdmZmbVgy?= =?utf-8?B?YXBpekV5alUyR01Wb2p2ZzZTM0JESmM4Sm0rUVlrYVFydmRlR3FqbWlDR0xa?= =?utf-8?B?bXpwUjRlOE1YcEFBRktybFJkbnpNOE1FNklsOEhyNW4rdzZkQ2EzTDRYUUJw?= =?utf-8?B?SnVVQXlzUXBmVHZSMkRBSDJtdmJNZFFCd2JFeUc1enFicmdYVmxFYlpsRXdx?= =?utf-8?B?UTc0eU1tbU5CTmZCRGRwZERIYmp3ZldDMGVhWkFwNkQxbGZTMytYMjc2NzAy?= =?utf-8?B?Yi9vODdXeFU3Q1prL01xQXFwNWhJTzR0dXhrVGljYTFvM1ZGZmR4bEFJNnhp?= =?utf-8?B?djFrU045cERGbzRWK3JkS2JtRkZrbHFlOVdURVMrTUhGazE4OGkyazVScm1V?= =?utf-8?B?SXpKV1Ewa0FzUy9vUGdXYkM3eUNRYjNoY0d4L3lrbHordGRubVpMcCtubTNv?= =?utf-8?B?VnZUemZjdWlxcUpESTNtM2FaOVV4Zy9xUWdPVEJ4aktuUE1PRW5yYVBIb1JT?= =?utf-8?B?TEgrMm44RGhTcElabUg1ZTYwcnJHd3lIaDFISkdGd0FSaTQzaVpTSlpBellV?= =?utf-8?B?cDB4Zkk0Q0VXbVJ6a3laVVFUNWRoekZCalV6UWNrcEpaTFdLWDdQR25mZXFv?= =?utf-8?B?YWl4V2czS2piRy9nMU81Nm9SZVRnU0NYTmlNMXJwcGdLdGc3V00yaUJlSktI?= =?utf-8?B?SlNlakdVdHZmWlZURkU3ZUFWT3pVQVp1STJ3NGovcGVzMzkwclRRSnlwVE1W?= =?utf-8?B?ZFQ4UjN0cVJzWjg0TWdLMTBhNFh4cGQ4TENBQm40RDdxVkFSOWVlTmNnVCtp?= =?utf-8?B?RVdGNXhicUJ3WkFIcUpKZU9JUmYxVHVteUcvaEo5VDNwc2ZzMVd4TTU0dmVm?= =?utf-8?B?djhZNnIvbXB4bXRJOE1hRGxnTHkxUnVLZ0FlYVNMc2lnZ0NTNUl6cEZnK1Z1?= =?utf-8?B?QjdJT2lyVGpBL2dTRXV4Mlk3Q0xGTlhrbkNHd2R5eWRkSzNwVHBzQVQ2djBO?= =?utf-8?B?WnZFZHJQck5NWUZ5bWMxZEZiWXJ6TGIxcVRQU2tkaUswRUpVRm1OY3NHUGFo?= =?utf-8?B?TThQRGFLaDZoVHBLbUxjNHFjemtNdkhBR1ZhZWp1K2lEUytRaHIxbXRraWNy?= =?utf-8?Q?5YZoVgwrAJY1FR1N0rMDP2H4VKlMk76GisjnJB5?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4213 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 98492d14-2e15-4008-4df3-08d91a3b169b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X1FMU5tmLx/CZYcQYsJk7akO0ZQBTvTOC13BiS/n1VsFd+7bXi80KA+SOC4nzcIJQoL625ku1XJ3gjYX+/JiR4crDX5Q50/Hb1+0FrJ37V6kOOhYWlIhfR/NNpncR2aM/znCOUhSXjuAkqdIIt4lXH4DQi9M3SVv3hVznO02JVeRUoLEvm6nNEhxQQFZA2O3dM6Bt+jhfqv8aVc6ndmK56q4aopWL9ZVPuHHYGJRsH44GJ7Dn8AMUkJs/5fD4fgyJjYWgL/jyWk/IsrSXpW2aPfqSikY8DlvT9tITUAgG7PIJdIdDc5kPYADrAxSs7KBMhskLHWQMceLOxewFPE7EneLvIFLFhXiAEkcRQPWqlUw9qyLjxL/ULVbPba5wATLHbPZgC938J+Z0Zl2wvF2WH7PWLxpxtwJQJt4VWPL/va9utqBT5a1hJzON8eayb9GP47KYubn+GUlT8Yb5NmPYNelL+2sp3OoZ8x6/9HAAmluv85OkRKqLelJsjLEtAvG7/HSWf4U5Vx8ubCLS88M1qsOjpREWUQ21jwbgwhE53VFWnGlWbR+XK7XpyQnxcaHmO9PpCk2vhMFt+wniRBlPjkoj4LBrrYDbmRIeOTbk0nuiXLE4HZ4rfaDPEbf5knnHXBTTyrGMjtN+QJMWkInLS+0g55W9neFkO5ax0gpWnKb9VZz4K0XF1tjnI0pqPUTeiRuzHEhTaFRmOGNX7vT9lxSWN+yo4VznR43Sbeis08= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39850400004)(346002)(376002)(396003)(136003)(36840700001)(46966006)(82310400003)(36860700001)(86362001)(26005)(356005)(81166007)(47076005)(478600001)(53546011)(2906002)(82740400003)(316002)(336012)(31686004)(70586007)(31696002)(16526019)(4326008)(16576012)(36756003)(2616005)(6486002)(44832011)(956004)(5660300002)(8936002)(70206006)(8676002)(186003)(43740500002)(14943795004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2021 20:25:41.3864 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f8104888-aaf2-418f-5726-08d91a3b1b6c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4195 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Hi Jianyon, Thank you for this patch. Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 17/05/2021 07:50 AM, Jianyong Wu wrote: > As there is lack of a machnism in Cloud Hypervisor to pass the base > address of Rsdp in Acpi, so a PCD varialbe is introduced here to [SAMI] Please fix the following typos: 'machnism' & 'varialbe' > feed it. > > Cc: Hao A Wu > Cc: Jian J Wang > Signed-off-by: Jianyong Wu > --- > MdeModulePkg/MdeModulePkg.dec | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec > index 148395511034..4c8baac35a9e 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -910,6 +910,13 @@ [PcdsFixedAtBuild] > # @Expression 0x80000001 | (gEfiMdeModulePkgTokenSpaceGuid.PcdLoadModuleAtFixAddressEnable == 0xFFFFFFFFFFFFFFFF || gEfiMdeModulePkgTokenSpaceGuid.PcdLoadModuleAtFixAddressEnable <= 0x0FFFFFFFFFFFFFFF) > gEfiMdeModulePkgTokenSpaceGuid.PcdLoadModuleAtFixAddressEnable|0|UINT64|0x30001015 > > + ## > + # This is the physical address of rsdp which is the core struct of Acpi. > + # Some hypervisor may has no way to pass rsdp address to the guest, so a PCD > + # is worth for those. > + # > + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiRsdpBaseAddress|0x0|UINT64|0x30001056 [SAMI] Can this PCD be defined in ArmVirtPkg\ArmVirtPkg.dec ? > + > ## Progress Code for OS Loader LoadImage start.

> # PROGRESS_CODE_OS_LOADER_LOAD = (EFI_SOFTWARE_DXE_BS_DRIVER | (EFI_OEM_SPECIFIC | 0x00000000)) = 0x03058000
> # @Prompt Progress Code for OS Loader LoadImage start.