From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A11AE210E3DDE for ; Fri, 10 Aug 2018 09:15:17 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E1CBC818A6BE; Fri, 10 Aug 2018 16:15:16 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-207.rdu2.redhat.com [10.10.120.207]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9E26610075D2; Fri, 10 Aug 2018 16:15:15 +0000 (UTC) From: Laszlo Ersek To: Eric Dong , edk2-devel@lists.01.org Cc: =?UTF-8?Q?Marvin_H=c3=a4user?= , Fan Jeff , Ruiyu Ni References: <20180810041909.12776-1-eric.dong@intel.com> <20180810041909.12776-4-eric.dong@intel.com> Message-ID: Date: Fri, 10 Aug 2018 18:15:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Fri, 10 Aug 2018 16:15:16 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Fri, 10 Aug 2018 16:15:16 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [Patch v3 3/5] UefiCpuPkg/CpuS3DataDxe: Change Memory Type and address limitation. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Aug 2018 16:15:17 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/10/18 18:12, Laszlo Ersek wrote: > On 08/10/18 06:19, Eric Dong wrote: >> Because CpuS3Data memory will be copy to smram at SmmReadyToLock point, >> the memory type no need to be ACPI NVS type, also the address not >> limit to below 4G. >> >> This change remove the limit of ACPI NVS memory type and below 4G. >> >> Pass OS boot and resume from S3 test. [snip] > (2) In the previous patch, we lifted the 4GB limitation on the stack > address (while preserving the memory type restriction as AcpiNVS). > However, you continue to allocate the stack with > AllocateAcpiNvsMemoryBelow4G(). > > I don't think that's consistent with the purpose of this patch set, or > with the documentation change in the previous patch. We should allocate > the stack as AcpiNVS without address limitation. > > And then we can remove the AllocateAcpiNvsMemoryBelow4G() function > altogether. Nevermind, I'm just seeing the next patch. (You might want to add a hint about the next patch to the commit message of this patch -- "we'll handle the stack in the next patch".) So only my question (1) remains for this patch, i.e. why not use AllocateZeroPages(). Thanks, Laszlo