From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2443221E43B6C for ; Fri, 22 Sep 2017 04:17:53 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6B283806C0; Fri, 22 Sep 2017 11:21:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6B283806C0 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-219.rdu2.redhat.com [10.10.120.219]) by smtp.corp.redhat.com (Postfix) with ESMTP id 93B5B6BF76; Fri, 22 Sep 2017 11:20:58 +0000 (UTC) To: Leif Lindholm Cc: edk2-devel@lists.01.org, Michael D Kinney , Jordan Justen , Andrew Fish , Ard Biesheuvel , "Gao, Liming" , "Zhu, Yonghong" References: <20170920172755.22767-1-leif.lindholm@linaro.org> <20170920210903.tdpj6prki4ikrlth@bivouac.eciton.net> From: Laszlo Ersek Message-ID: Date: Fri, 22 Sep 2017 13:20:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170920210903.tdpj6prki4ikrlth@bivouac.eciton.net> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 22 Sep 2017 11:21:00 +0000 (UTC) Subject: Re: [RFC 0/6] Create central repository for boilerplate configuration X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Sep 2017 11:17:53 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/20/17 23:09, Leif Lindholm wrote: > On Wed, Sep 20, 2017 at 08:14:59PM +0200, Laszlo Ersek wrote: >> (2) Replacing a build define called FOOBAR with CONFIG_FOOBAR will break >> all downstream build scripts. Is the CONFIG_ prefix a requirement? > > It was explicitly intended to break compatibility, to ensure we didn't > end up with things accidentally working until something unrelated > changed in the future. Interesting idea. I guess we could try to reach out to all of the "repeat builders" of OVMF. > >> (3) I think PCDs should not be included in ConfigPkg DSC include files, >> even if several platforms set the same value. The set of libraries and >> driver modules commonly used for a given feature is mostly constant >> across platforms (and it is easy to extend, incrementally); but I don't >> think the same holds for PCDs. Especially if a user wants to change a >> PCD for one platform but not the other. Even if repeated settings for a >> PCD worked (all on the same level of "specificity"), I'd find the result >> confusing. > > Also a subject for discussion. > My intent was that if most of the open source platforms had an > override on the default of a particular Pcd, we could override it in > the config fragments without changing the .dec (and affecting > non-public ports). Right, that's great... > Individual platforms can still override (again). ... but this "again" part is what confuses me (assuming it would technically work). We'd have a PCD default in the .dec, then a setting in the central .dsc.inc that ultimately qualifies as a platform-level setting, and finally a setting in the actual platform .dsc, which *also* qualifies as a platform-level setting. IOW, one in the .dec, and two in the (final) .dsc. I have no clue if this works, but even if it does, the priority could depend on the order of inclusion, which I find confusing. Liming, Yonghong, can you guys please comment on this? Thanks! Laszlo