* [patch] MdeModulePkg/XhciPei: 1ms delay before accessing MMIO reg in reset
@ 2016-09-14 1:49 Feng Tian
2016-09-14 2:56 ` Zeng, Star
0 siblings, 1 reply; 2+ messages in thread
From: Feng Tian @ 2016-09-14 1:49 UTC (permalink / raw)
To: star.zeng; +Cc: edk2-devel
Some XHCI HCs require to have 1ms delay before accessing any MMIO
register in reset.
Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Feng Tian <feng.tian@intel.com>
---
MdeModulePkg/Bus/Pci/XhciPei/XhcPeim.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/MdeModulePkg/Bus/Pci/XhciPei/XhcPeim.c b/MdeModulePkg/Bus/Pci/XhciPei/XhcPeim.c
index a58739f..cd5c5cd 100644
--- a/MdeModulePkg/Bus/Pci/XhciPei/XhcPeim.c
+++ b/MdeModulePkg/Bus/Pci/XhciPei/XhcPeim.c
@@ -407,6 +407,7 @@ XhcPeiResetHC (
}
XhcPeiSetOpRegBit (Xhc, XHC_USBCMD_OFFSET, XHC_USBCMD_RESET);
+ MicroSecondDelay (1000);
Status = XhcPeiWaitOpRegBit (Xhc, XHC_USBCMD_OFFSET, XHC_USBCMD_RESET, FALSE, Timeout);
ON_EXIT:
DEBUG ((EFI_D_INFO, "XhcPeiResetHC: %r\n", Status));
--
2.7.1.windows.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] MdeModulePkg/XhciPei: 1ms delay before accessing MMIO reg in reset
2016-09-14 1:49 [patch] MdeModulePkg/XhciPei: 1ms delay before accessing MMIO reg in reset Feng Tian
@ 2016-09-14 2:56 ` Zeng, Star
0 siblings, 0 replies; 2+ messages in thread
From: Zeng, Star @ 2016-09-14 2:56 UTC (permalink / raw)
To: Tian, Feng; +Cc: edk2-devel@lists.01.org
Reviewed-by: Star Zeng <star.zeng@intel.com>
-----Original Message-----
From: Tian, Feng
Sent: Wednesday, September 14, 2016 9:49 AM
To: Zeng, Star <star.zeng@intel.com>
Cc: edk2-devel@lists.01.org
Subject: [patch] MdeModulePkg/XhciPei: 1ms delay before accessing MMIO reg in reset
Some XHCI HCs require to have 1ms delay before accessing any MMIO register in reset.
Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Feng Tian <feng.tian@intel.com>
---
MdeModulePkg/Bus/Pci/XhciPei/XhcPeim.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/MdeModulePkg/Bus/Pci/XhciPei/XhcPeim.c b/MdeModulePkg/Bus/Pci/XhciPei/XhcPeim.c
index a58739f..cd5c5cd 100644
--- a/MdeModulePkg/Bus/Pci/XhciPei/XhcPeim.c
+++ b/MdeModulePkg/Bus/Pci/XhciPei/XhcPeim.c
@@ -407,6 +407,7 @@ XhcPeiResetHC (
}
XhcPeiSetOpRegBit (Xhc, XHC_USBCMD_OFFSET, XHC_USBCMD_RESET);
+ MicroSecondDelay (1000);
Status = XhcPeiWaitOpRegBit (Xhc, XHC_USBCMD_OFFSET, XHC_USBCMD_RESET, FALSE, Timeout);
ON_EXIT:
DEBUG ((EFI_D_INFO, "XhcPeiResetHC: %r\n", Status));
--
2.7.1.windows.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-14 2:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-14 1:49 [patch] MdeModulePkg/XhciPei: 1ms delay before accessing MMIO reg in reset Feng Tian
2016-09-14 2:56 ` Zeng, Star
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox