Re: [edk2-devel] SMBIOS BIOS ROM Size

["Leif Lindholm" <quic_llindhol@quicinc.com>]

On 2024-05-30 12:58, Rebecca Cran wrote:
> On 5/30/2024 4:06 AM, Leif Lindholm via groups.io wrote:
>> While reviewing https://github.com/tianocore/edk2/pull/5702, I found 
>> myself wondering "shouldn't this (doesn't apply to UEFI-based systems) 
>> be the case for the size field also?".
>>
>> But the SMBIOS spec is quite clear that the size field refers to the 
>> size of the physical device the BIOS is stored on.
>>
>> Currently, this field is hardwired to PcdFdSize in the smbios helper 
>> library. But that would only be accurate for platforms that use the 
>> edk2 build system to generate the final flashable image to a fixed size.
>>
>> This isn't really true for SbsaQemu, and I don't think it is for Mt. 
>> Jade. And those are the only two upstream platforms using this 
>> SmbiosMiscDxe.
>>
>> Do we need to solve this by adding another function for OemMiscLib?
> 
> I still need to update ArmVirtPkg to use it, but I have this commit 
> waiting to be submitted:

Ah, excellent :)

/
     Leif

> commit e6d4d2a8cf995a7f4f60e7f55ff2ab494308f939
> Author: Rebecca Cran <rebecca@bsdio.com>
> Date:   Wed May 15 09:10:54 2024 -0600
> 
>      ArmPkg: Add new function OemGetPhysicalBiosSize to OemMiscLib
> 
>      The FD size often isn't the same as the physical size of the SPI-NOR
>      EEPROM it gets written to, but is instead combined with other files 
> and
>      data to create the final image. Add a function 
> `OemGetPhysicalBiosSize`
>      which allows platforms to provide the actual size of the EEPROM for
>      SMBIOS.
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119399): https://edk2.groups.io/g/devel/message/119399
Mute This Topic: https://groups.io/mt/106385738/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-