From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1B5E6740038 for ; Thu, 30 May 2024 16:10:19 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=LIXeaX6dE4zD+JUrMJKrCA+Pr2Dqz1Pb9c1EX6KN/s0=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:CC:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1717085419; v=1; b=sak7L67J0PTRUSg6sS3sqSG5j/VH8RtqpdAeFrxsZrIu85hH9LAtI8HNYDRXwe2cUnpi88Cb Ak8wlTFxKQvCrAm7opG6EI5ZkjRq+6D60rg9aNr6yDQfaK+kUKbfnb1jH/1LY/fS88qsaekeWBp sDa5eYmjZ9d/6Ac/06BBuYBni68JgNXOVUxboSE6sHaYSE9grsAhDRUIQ+HG8ougCNMgw7N1ZSE m4+lT/5v4vuciOL6al4bo25SBxy5hdYRszI+/f3/O04woTn8kaCb2vSRghXSFxA0mEmidxlUH8T 4O8l/X36IId0l0b0pogXJG5wwiNb8zDRO9d2xoFRGkYag== X-Received: by 127.0.0.2 with SMTP id FAGnYY7687511xmEZPQ06VyB; Thu, 30 May 2024 09:10:18 -0700 X-Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web11.175.1717085412751832470 for ; Thu, 30 May 2024 09:10:12 -0700 X-Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 44UFjY6l006607; Thu, 30 May 2024 16:10:07 GMT X-Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3ye96bjsfb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 30 May 2024 16:10:06 +0000 (GMT) X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 44UGA5dg005451 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 30 May 2024 16:10:05 GMT X-Received: from [10.111.132.194] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Thu, 30 May 2024 09:10:04 -0700 Message-ID: Date: Thu, 30 May 2024 17:10:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] SMBIOS BIOS ROM Size To: Rebecca Cran , CC: Ard Biesheuvel , Sami Mujawar References: <45c7db99-9b36-43c1-aceb-50705fe350dc@quicinc.com> <6d21aff5-6972-44cb-9e0a-9c43ea52d196@bsdio.com> From: "Leif Lindholm" In-Reply-To: <6d21aff5-6972-44cb-9e0a-9c43ea52d196@bsdio.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-GUID: c1C643cilGpP1jcrpadBiHcM7OFfZfoz X-Proofpoint-ORIG-GUID: c1C643cilGpP1jcrpadBiHcM7OFfZfoz X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-0031df01.pphosted.com id 44UFjY6l006607 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 30 May 2024 09:10:12 -0700 Resent-From: quic_llindhol@quicinc.com Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: VcSBYRhRtakHkSGRu6EkBiiXx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=sak7L67J; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On 2024-05-30 12:58, Rebecca Cran wrote: > On 5/30/2024 4:06 AM, Leif Lindholm via groups.io wrote: >> While reviewing https://github.com/tianocore/edk2/pull/5702, I found=20 >> myself wondering "shouldn't this (doesn't apply to UEFI-based systems)= =20 >> be the case for the size field also?". >> >> But the SMBIOS spec is quite clear that the size field refers to the=20 >> size of the physical device the BIOS is stored on. >> >> Currently, this field is hardwired to PcdFdSize in the smbios helper=20 >> library. But that would only be accurate for platforms that use the=20 >> edk2 build system to generate the final flashable image to a fixed size. >> >> This isn't really true for SbsaQemu, and I don't think it is for Mt.=20 >> Jade. And those are the only two upstream platforms using this=20 >> SmbiosMiscDxe. >> >> Do we need to solve this by adding another function for OemMiscLib? >=20 > I still need to update ArmVirtPkg to use it, but I have this commit=20 > waiting to be submitted: Ah, excellent :) / Leif > commit e6d4d2a8cf995a7f4f60e7f55ff2ab494308f939 > Author: Rebecca Cran > Date:=C2=A0=C2=A0 Wed May 15 09:10:54 2024 -0600 >=20 > =C2=A0=C2=A0=C2=A0 ArmPkg: Add new function OemGetPhysicalBiosSize to Oe= mMiscLib >=20 > =C2=A0=C2=A0=C2=A0 The FD size often isn't the same as the physical size= of the SPI-NOR > =C2=A0=C2=A0=C2=A0 EEPROM it gets written to, but is instead combined wi= th other files=20 > and > =C2=A0=C2=A0=C2=A0 data to create the final image. Add a function=20 > `OemGetPhysicalBiosSize` > =C2=A0=C2=A0=C2=A0 which allows platforms to provide the actual size of = the EEPROM for > =C2=A0=C2=A0=C2=A0 SMBIOS. >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119399): https://edk2.groups.io/g/devel/message/119399 Mute This Topic: https://groups.io/mt/106385738/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-