From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A8AD8941D6D for ; Wed, 31 Jan 2024 19:13:20 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Oig7VFBxIYv9r6EPDwezUaXFfN5EcO5oG7qxn7ZqXpA=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706728399; v=1; b=di61wg8HS3QuUeByrAkaQbfSEx8H0Z15pcXVjLz0ZbTCvx4ezl8xfLm9UpjVPLz6XHUwD3Th bwS9mdJu7VqphM2GeAft4p8JFOn9+PJEV/MQjzdq1tE/W4ZXGT5HTCkAYik9s/0DM/R5eQIIleU garzFb+wC2UPiGOLvm8T7XuY= X-Received: by 127.0.0.2 with SMTP id k8K3YY7687511xHnp3tbfBVW; Wed, 31 Jan 2024 11:13:19 -0800 X-Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web11.3855.1706728398381202055 for ; Wed, 31 Jan 2024 11:13:18 -0800 X-Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40VEA7un001454; Wed, 31 Jan 2024 19:13:18 GMT X-Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3vypaq0yby-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 31 Jan 2024 19:13:17 +0000 (GMT) X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 40VJDHd9002892 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 31 Jan 2024 19:13:17 GMT X-Received: from [10.111.128.227] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Wed, 31 Jan 2024 11:13:15 -0800 Message-ID: Date: Wed, 31 Jan 2024 19:13:13 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: FW: [edk2-devel] [PATCH V2 4/5] ArmPlatformPkg: Update some Runtime Service functions header To: "Ren, SuqiangX" , "ardb+tianocore@kernel.org" , "devel@edk2.groups.io" References: <17AEB08976789B0D.21687@groups.io> From: "Leif Lindholm" In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-ORIG-GUID: VcurmwAYNOcxb54yMaOPWW_KyDEQrWfb X-Proofpoint-GUID: VcurmwAYNOcxb54yMaOPWW_KyDEQrWfb X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-0031df01.pphosted.com id 40VEA7un001454 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Jo4kHw4t5Of95QiFoLgAapnWx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=di61wg8H; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 2024-01-30 08:33, Ren, SuqiangX wrote: > Hi All, >=20 > Could you please help to review this patch on edk2? > https://edk2.groups.io/g/devel/message/114661 >=20 > Thanks > Ren, Suqiang Hi, Sorry, your original email seems to be corrupted in my mailbox, so=20 replying here. > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Ren, Suqia= ng > Sent: Monday, January 29, 2024 10:30 AM > To: devel@edk2.groups.io > Cc: Leif Lindholm ; Ard Biesheuvel > Subject: [edk2-devel] [PATCH V2 4/5] ArmPlatformPkg: Update some Runtime = Service functions header >=20 > Update some Runtime Service functions header to align with UEFI spec 2.10= . >=20 > REF: UEFI spec 2.10 section 8 Services =E2=80=94 Runtime Services Nothing that is being changed by this patch is described by the UEFI=20 specification. The commit message should describe what a patch does, the overall purpose of the set should be described in the cover letter=20 (and you do describe that here). Here is my proposed changed commit message: --- ArmPlatformPkg: align PL031 library function headers with UEFI return value= s RealTimeClockLib is used to back the runtime services time functions, so align the description of the function return values with the defined values for these services as described in UEFI 2.10. --- Apart from that, the function comment headers exist both in the .h and=20 the .c. If the .h is being updated, so should the .c. Best Regards, Leif > Signed-off-by: Suqiang Ren > Cc: Leif Lindholm > Cc: Ard Biesheuvel > --- > .../PL031RealTimeClockLib.c | 22 +++++++++++++++---- > 1 file changed, 18 insertions(+), 4 deletions(-) >=20 > diff --git a/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeCl= ockLib.c b/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockL= ib.c > index 1896f9d16d3b..6ab3e9948335 100644 > --- a/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.= c > +++ b/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.= c > @@ -111,7 +111,9 @@ EXIT: > @retval EFI_SUCCESS The operation completed successfully. > @retval EFI_INVALID_PARAMETER Time is NULL. > @retval EFI_DEVICE_ERROR The time could not be retrieved due to= hardware error. > - @retval EFI_SECURITY_VIOLATION The time could not be retrieved due to = an authentication failure. > + @retval EFI_UNSUPPORTED This call is not supported by this plat= form at the time the call is made. > + The platform should describe this runti= me service as unsupported at runtime > + via an EFI_RT_PROPERTIES_TABLE configur= ation table. > =20 > **/ > EFI_STATUS > @@ -172,6 +174,9 @@ LibGetTime ( > @retval EFI_SUCCESS The operation completed successfully. > @retval EFI_INVALID_PARAMETER A time field is out of range. > @retval EFI_DEVICE_ERROR The time could not be set due to hardwa= re error. > + @retval EFI_UNSUPPORTED This call is not supported by this platf= orm at the time the call is made. > + The platform should describe this runtim= e service as unsupported at runtime > + via an EFI_RT_PROPERTIES_TABLE configura= tion table. > =20 > **/ > EFI_STATUS > @@ -224,8 +229,13 @@ LibSetTime ( > @param Time The current alarm setting. > =20 > @retval EFI_SUCCESS The alarm settings were returned. > - @retval EFI_INVALID_PARAMETER Any parameter is NULL. > + @retval EFI_INVALID_PARAMETER Enabled is NULL. > + @retval EFI_INVALID_PARAMETER Pending is NULL. > + @retval EFI_INVALID_PARAMETER Time is NULL. > @retval EFI_DEVICE_ERROR The wakeup time could not be retrieved = due to a hardware error. > + @retval EFI_UNSUPPORTED This call is not supported by this platf= orm at the time the call is made. > + The platform should describe this runtim= e service as unsupported at runtime > + via an EFI_RT_PROPERTIES_TABLE configura= tion table. > =20 > **/ > EFI_STATUS > @@ -248,9 +258,13 @@ LibGetWakeupTime ( > =20 > @retval EFI_SUCCESS If Enable is TRUE, then the wakeup alar= m was enabled. If > Enable is FALSE, then the wakeup alarm = was disabled. > - @retval EFI_INVALID_PARAMETER A time field is out of range. > + @retval EFI_INVALID_PARAMETER Enabled is NULL. > + @retval EFI_INVALID_PARAMETER Pending is NULL. > + @retval EFI_INVALID_PARAMETER Time is NULL. > @retval EFI_DEVICE_ERROR The wakeup time could not be set due to= a hardware error. > - @retval EFI_UNSUPPORTED A wakeup timer is not supported on this = platform. > + @retval EFI_UNSUPPORTED This call is not supported by this platf= orm at the time the call is made. > + The platform should describe this runtim= e service as unsupported at runtime > + via an EFI_RT_PROPERTIES_TABLE configura= tion table. > =20 > **/ > EFI_STATUS -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114916): https://edk2.groups.io/g/devel/message/114916 Mute This Topic: https://groups.io/mt/104081753/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-