From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 73F3E941CD8 for ; Fri, 17 Nov 2023 16:07:05 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=YrkSO6o2W99v0YpYuGeYzvFTz3zEVSepW0JMMYj1dus=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:References:From:Cc:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700237223; v=1; b=nP4IMbvdRYiDBiozwpnCOYJAMI2Wlpd2R/myTrXPmszBaVpfHfWih9yv6fjFt+ETIKJvAiJl kIaIRBy6y8KgnCY/ttYCSrpIlawYG+n8DxwBSendpMGkvvPFmT0PNjZQ3GgZgBNQz9CtD4adhFW WvK8UM1kF/WXOvfeqYMwMMGc= X-Received: by 127.0.0.2 with SMTP id e4ZXYY7687511xUIWjxC960r; Fri, 17 Nov 2023 08:07:03 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.15064.1700237223318605756 for ; Fri, 17 Nov 2023 08:07:03 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-26-w158R5N0MP24oGgXBu4Xsg-1; Fri, 17 Nov 2023 11:06:58 -0500 X-MC-Unique: w158R5N0MP24oGgXBu4Xsg-1 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 749B03C0BE4F; Fri, 17 Nov 2023 16:06:58 +0000 (UTC) X-Received: from [10.39.193.21] (unknown [10.39.193.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5A5A52166B28; Fri, 17 Nov 2023 16:06:57 +0000 (UTC) Message-ID: Date: Fri, 17 Nov 2023 17:06:56 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [Bug] Building NetworkPkg fails due to missing SynchronizationLib dependency of BaseCryptLib To: devel@edk2.groups.io, crossedcarpet@hotmail.com References: From: "Laszlo Ersek" Cc: "Liming Gao (Byosoft address)" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: q5N7BNwaAS7XcIcy4izA7NK4x7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=nP4IMbvd; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 11/17/23 13:49, CrossedCarpet wrote: > Steps to reproduce: > - download and setup edk2 > - run: > build -a X64 -b DEBUG -t GCC -p NetworkPkg/NetworkPkg.dsc > > Get the error: > build.py... > /.../edk2/NetworkPkg/NetworkPkg.dsc(...): error 4000: Instance of > library class [SynchronizationLib] is not found > in [/.../edk2/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf] [X64] > consumed by module [/.../edk2/NetworkPkg/TlsDxe/TlsDxe.inf] > > Adding this LibClass to NetworkPkg.dsc solves it: >   > SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf This is a regression from commit 5d5be45bd111 ("CryptPkg: Enable CryptoPkg BaseCryptLib ParallelHash for PEI and DXE", 2022-12-02), which was made for . It added a new lib class dependency to "BaseCryptLib.inf", but it didn't ensure that all DSC files in the tree that employed the "BaseCryptLib.inf" instance had a resolution for the new lib class. Indeed it is not just NetworkPkg.dsc but also FmpDevicePkg.dsc that's affected: $ git grep -l -F CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf -- '**dsc*' \ | xargs -- grep --files-without-match -w SynchronizationLib -- FmpDevicePkg/FmpDevicePkg.dsc NetworkPkg/NetworkPkg.dsc It also *seems* to affect at least one platform in edk2-platforms: Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc (although I realize this last DSC file is an "include" DSC, so the missing dependency could be resolved in the DSC file that includes this one.) Either way, thanks for catching this; the edk2 issue should be fixed preferably during the current hard feature freeze (for NetworkPkg and FmpDevicePkg). > I tried to open a bug in bugzilla but I wasn't able to log in or create > an account. How should I do it next time? I think the bugzilla account creation was disabled due to spammer accounts. The way to request an account is described here (linked from the bugzilla.tianocore.org landing page under link "Reporting issues"): https://github.com/tianocore/tianocore.github.io/wiki/Reporting-Issues (I've added Liming to the CC list of this email.) Laszlo > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111402): https://edk2.groups.io/g/devel/message/111402 Mute This Topic: https://groups.io/mt/102646401/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-