public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: devel@edk2.groups.io, kuqin12@gmail.com
Cc: Leif Lindholm <quic_llindhol@quicinc.com>,
	Peng Xie <xiepeng@phytium.com.cn>,
	Ling Jia <jialing@phytium.com.cn>,
	Yiqi Shu <shuyiqi@phytium.com.cn>,
	nd@arm.com
Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 7/7] PhytiumCommonPkg: Pipeline: Resolving newly introduced dependency
Date: Fri, 29 Jul 2022 19:45:51 +0100	[thread overview]
Message-ID: <bb4090c5-e1f7-5496-2b7e-fa9d46bc4dc4@arm.com> (raw)
In-Reply-To: <20220721200730.1811-8-kuqin12@gmail.com>

Hi Kun,

Thank you for this patch.

This change fixes the build break for Phytium platforms.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 21/07/2022 09:07 pm, Kun Qin via groups.io wrote:
> The new changes in SecureBootVariableLib brought in a new dependency
> of PlatformPKProtectionLib.
>
> This change added the new library instance from SecurityPkg to resolve
> PhytiumCommonPkg platforms build.
>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Peng Xie <xiepeng@phytium.com.cn>
> Cc: Ling Jia <jialing@phytium.com.cn>
> Cc: Yiqi Shu <shuyiqi@phytium.com.cn>
>
> Signed-off-by: Kun Qin <kuqin12@gmail.com>
> ---
>
> Notes:
>      v2:
>      - No review, no change.
>
>   Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc b/Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc
> index 2565b8ac626a..42fe2a5c2246 100644
> --- a/Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc
> +++ b/Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc
> @@ -83,6 +83,7 @@ [LibraryClasses.common]
>     SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
>
>     SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
>
>     SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
>
> +  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
>
>   
>
>     TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf
>
>     TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
>

      reply	other threads:[~2022-07-29 18:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-21 20:07 [edk2-platforms][PATCH v2 0/7] Resolving SecureBootVariableLib dependency Kun Qin
2022-07-21 20:07 ` [edk2-platforms][PATCH v2 1/7] RaspberryPi: Pipeline: Resolving newly introduced dependency Kun Qin
2022-07-21 20:07 ` [edk2-platforms][PATCH v2 2/7] U5SeriesPkg: " Kun Qin
2022-07-21 20:07 ` [edk2-platforms][PATCH v2 3/7] VExpressPkg: " Kun Qin
2022-07-21 20:07 ` [edk2-platforms][PATCH v2 4/7] Qemu: " Kun Qin
2022-07-21 20:07 ` [edk2-platforms][PATCH v2 5/7] Socionext: " Kun Qin
2022-07-21 20:07 ` [edk2-platforms][PATCH v2 6/7] AmpereAltraPkg: " Kun Qin
2022-07-21 20:07 ` [edk2-platforms][PATCH v2 7/7] PhytiumCommonPkg: " Kun Qin
2022-07-29 18:45   ` Sami Mujawar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb4090c5-e1f7-5496-2b7e-fa9d46bc4dc4@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox