Re: [PATCH v2 0/6] read-only UDF file system support

[Paulo Alcantara <pcacjr@zytor.com>]

Hi,

I do apologize my late replies. At the moment, I'm only able to work on 
this during my free time. Thank you all for the reviews!

FWIW, my comments below.

On 8/20/2017 11:29 PM, Ni, Ruiyu wrote:
> Paulo,
> 1. Could you please run the ECC check tool (BaseTools\Source\Python\Ecc\)
>    "CRC" might need to be replaced with "Crc".
>    I also noticed some TAB key in file content.

Sure.

> 
> 2. Your current implementation uses HARD_DRIVE_DEVICE_PATH.
>    But with:
>       SignatureType = SIGNATURE_TYPE_UDF
>       MBRType = MBR_TYPE_PCAT
>       Signature = *
>    And later UdfDxe driver checks the SignatureType and MBRType.
>    I am not sure if it would be better to put the definitions in UEFI Spec,
>    since they are referenced by different modules.
>    I also noticed you use PARTITION_TYPE_OTHER for PartitionInfo.
>    When proposing to UEFI Spec, this also needs to be considered,
>    for example, add PARTITION_TYPE_UDF to spec.

Yes - I agree with you. My only concern is that UEFI specification 
doesn't either support UDF or there is any interest in supporting it, so 
by proposing an additional type for something that shouldn't be 
supported, might not work out.

(Andrew, any thoughts?)

"PARTITION_TYPE_OTHER" is also used when creating 
EFI_PARTITION_INFO_PROTOCOL for CDROM "El Torito" partitions, so either 
we could follow the same approach, or propose creating two other types: 
e.g., PARTITION_TYPE_ELTORITO and PARTITION_TYPE_UDF.

> 
> 3. The driver model part looks good.

Cool! Thanks for looking into that.

Paulo