Re: [PATCH v2 0/4] Add extra pci roots support for Arm

["Ard Biesheuvel" <ard.biesheuvel@arm.com>]

On 11/9/20 2:05 PM, Jiahui Cen wrote:
> Changes with v1
> v1->v2:
> Separated into four patches.
> Factor the same logic parts into a new library.
> 
> v1: https://edk2.groups.io/g/devel/topic/72723351#56901
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3059
> QEMU: https://lore.kernel.org/qemu-devel/20201103120157.2286-1-cenjiahui@huawei.com/
> 
> This patch series adds support for extra pci roots for ARM.
> 

Why?


> In order to avoid duplicated codes, we introduce a new library
> PciHostBridgeUtilityLib which extracts common interfaces from
> OvmfPkg/PciHostBridgeLib. It provides conflicts informing and extra pci
> roots scanning. Using the utility lib, the uefi could scan for extra
> root buses and recognize multiple roots for ARM.
> 
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Signed-off-by: Yubo Miao <miaoyubo@huawei.com>
> Signed-off-by: Jiahui Cen <cenjiahui@huawei.com>
> 
> Yubo Miao (4):
>    OvmfPkg: Extract functions form PciHostBridgeLib
>    ArmVirtPkg: Use extracted PciHostBridgeUtilityLib
>    OvmfPkg: Extract functions of extra pci roots
>    ArmVirtPkg: Support extra pci roots
> 
>   ArmVirtPkg/ArmVirt.dsc.inc                                          |   1 +
>   OvmfPkg/OvmfPkgIa32.dsc                                             |   1 +
>   OvmfPkg/OvmfPkgIa32X64.dsc                                          |   1 +
>   OvmfPkg/OvmfPkgX64.dsc                                              |   1 +
>   OvmfPkg/OvmfXen.dsc                                                 |   1 +
>   ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf      |   5 +
>   OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf               |   1 +
>   OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf |  51 ++++
>   OvmfPkg/Include/Library/PciHostBridgeUtilityLib.h                   |  98 +++++++
>   ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c        | 221 ++++++++-------
>   OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c                 | 234 +---------------
>   OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.c   | 283 ++++++++++++++++++++
>   12 files changed, 563 insertions(+), 335 deletions(-)
>   create mode 100644 OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf
>   create mode 100644 OvmfPkg/Include/Library/PciHostBridgeUtilityLib.h
>   create mode 100644 OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.c
>