From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.96501.1673327428388009207 for ; Mon, 09 Jan 2023 21:10:28 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Sgq6Gx20; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673327427; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r2DG1RY5dZLgwFJGRO8BGglB5jqq78naFZ/7ENx2KlI=; b=Sgq6Gx20MHZz2omdbows7iClLFOEOkUMSXUoAUC/n24gxQT3YNrkqZAWBfYPWLyzDjt22W 2I1TfaBtWYq0/DA6OBdZcI29vFRSA++esQvpkT444CFri3hNmsk7y7AQFXPYWGVS+T70Jz YQyVTuooJSKa8QyXrHfCZZPe32qxVdc= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-590-ZAZLEF5WNY-bbCQxeXCoJA-1; Tue, 10 Jan 2023 00:10:24 -0500 X-MC-Unique: ZAZLEF5WNY-bbCQxeXCoJA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C845E1C068D6; Tue, 10 Jan 2023 05:10:23 +0000 (UTC) Received: from [10.39.192.22] (unknown [10.39.192.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5AA35492B00; Tue, 10 Jan 2023 05:10:10 +0000 (UTC) Message-ID: Date: Tue, 10 Jan 2023 06:10:09 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH V2 4/6] OvmfPkg/AcpiPlatformDxe: Add log to show the installed tables To: devel@edk2.groups.io, min.m.xu@intel.com Cc: Erdem Aktas , James Bottomley , Jiewen Yao , Gerd Hoffmann , Tom Lendacky References: <20230109135917.1752-1-min.m.xu@intel.com> <20230109135917.1752-5-min.m.xu@intel.com> From: "Laszlo Ersek" In-Reply-To: <20230109135917.1752-5-min.m.xu@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/9/23 14:59, Min Xu wrote: > From: Min M Xu > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4237 > > Commit 9fdc70af6ba8 wrongly removed the log from InstallQemuFwCfgTables > after ACPI tables are successfully installed. This patch add the log > back after all operations succeed. > > Cc: Laszlo Ersek > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Gerd Hoffmann > Cc: Tom Lendacky > Reported-by: Laszlo Ersek > Signed-off-by: Min Xu > --- > OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c b/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c > index 693cb8c8a83e..f27a95957f47 100644 > --- a/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c > +++ b/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c > @@ -1266,6 +1266,8 @@ InstallQemuFwCfgTables ( > S3Context = NULL; > } > > + DEBUG ((DEBUG_INFO, "%a: installed %d tables\n", __FUNCTION__, Installed)); > + > UninstallAcpiTables: > if (EFI_ERROR (Status)) { > // Reviewed-by: Laszlo Ersek