From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by mx.groups.io with SMTP id smtpd.web08.6774.1634899812496236495 for ; Fri, 22 Oct 2021 03:50:12 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@ibm.com header.s=pp1 header.b=KIGX7b5x; spf=pass (domain: linux.ibm.com, ip: 148.163.156.1, mailfrom: stefanb@linux.ibm.com) Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19M8hWX1021028; Fri, 22 Oct 2021 06:50:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=RlyYpmHncDY4/lbuvjOf09zOQ9R3oOHVZBHn1oTS1GM=; b=KIGX7b5xYeq8KJIE/qYgElaPn72xBb4Peg8mVtvkGUkZn1mLC6k4/GHO43M9LMaH1DS/ X2KiJLiv6h7p7m9ZyzyUTo76WsvGZWCy83IPsYjeNxQ9cXrUBAJwWfkyH5jfHvLhrXvJ IcFhhGqLiM3hV7UXEe91cb39IiyU0WuUKW6RC09kfkrjdogt8906amVT1L6+7DN4LviP 8QYMiiKhi0gVeBdNUs3+ySGrfx3Uoxly48ezrJxJRB/u7C0WJdIz5kaoNgcewOj3z9gt rYgKiRSsoVp8g9yRAyZNkjRl8Y7DYS9vFjocQLYKwe1Uf5GrCnj1WfvRp3h8T3fkqvzp 6A== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3bua9hngcq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 22 Oct 2021 06:50:10 -0400 Received: from m0098399.ppops.net (m0098399.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 19MAkEBK012042; Fri, 22 Oct 2021 06:50:09 -0400 Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0a-001b2d01.pphosted.com with ESMTP id 3bua9hngc5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 22 Oct 2021 06:50:09 -0400 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 19MAlcpO013043; Fri, 22 Oct 2021 10:50:08 GMT Received: from b01cxnp22036.gho.pok.ibm.com (b01cxnp22036.gho.pok.ibm.com [9.57.198.26]) by ppma03dal.us.ibm.com with ESMTP id 3bqpcdny0r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 22 Oct 2021 10:50:08 +0000 Received: from b01ledav001.gho.pok.ibm.com (b01ledav001.gho.pok.ibm.com [9.57.199.106]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 19MAo7u011010622 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 22 Oct 2021 10:50:07 GMT Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5879328067; Fri, 22 Oct 2021 10:50:07 +0000 (GMT) Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 42FC428065; Fri, 22 Oct 2021 10:50:07 +0000 (GMT) Received: from [9.47.158.152] (unknown [9.47.158.152]) by b01ledav001.gho.pok.ibm.com (Postfix) with ESMTP; Fri, 22 Oct 2021 10:50:07 +0000 (GMT) Subject: Re: [PATCH 4/4] OvmfPkg: add TPM2_SHA1_ENABLE build option To: Gerd Hoffmann Cc: devel@edk2.groups.io, James Bottomley , Min Xu , Jordan Justen , Erdem Aktas , Ard Biesheuvel , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Jiewen Yao , Tom Lendacky , Brijesh Singh References: <20211021122003.2008499-1-kraxel@redhat.com> <20211021122003.2008499-5-kraxel@redhat.com> <03a75199-000f-5575-8898-6d9b113f2bee@linux.ibm.com> <20211022063948.mratwrzgponwiulg@sirius.home.kraxel.org> From: "Stefan Berger" Message-ID: Date: Fri, 22 Oct 2021 06:50:07 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20211022063948.mratwrzgponwiulg@sirius.home.kraxel.org> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 2ivirYkxrwF-krzJ4-oGlRSTrbzSAc3i X-Proofpoint-ORIG-GUID: -VB4y6hPksHzWHENhILigjX29ZlTlqce X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-10-22_03,2021-10-21_02,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 bulkscore=0 adultscore=0 mlxscore=0 mlxlogscore=999 phishscore=0 impostorscore=0 spamscore=0 malwarescore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001 definitions=main-2110220058 X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-001b2d01.pphosted.com id 19M8hWX1021028 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 10/22/21 2:39 AM, Gerd Hoffmann wrote: > On Thu, Oct 21, 2021 at 09:24:55AM -0400, Stefan Berger wrote: >> On 10/21/21 8:20 AM, Gerd Hoffmann wrote: >>> Allows to compile OVMF without HashInstanceLibSha1, >>> i.e. no SHA1 hash support in TPM/TCG modules. >> Does that then mean that the SHA1 bank in a TPM 2 stays untouched, mea= ning >> the PCRs there won't get extended even though the bank is there and ac= tive? > Not fully sure. The tcg2 config menu looks like this: > > [ ... ] > TPM2 Active PCR Hash SHA1, SHA256 > Algorithm > TPM2 Hardware Supported SHA1, SHA256, SHA384, > Hash Algorithm SHA512 > BIOS Supported Hash SHA256, SHA384, SHA512 > Algorithm > [ ... ] > TCG2 Protocol Configuration > Supported Event Log Format TCG_2 > Hash Algorithm Bitmap SHA256, SHA384, SHA512 > Number of PCR Banks 3 > Active PCR Banks SHA256 > > PCR Bank: SHA1 [ ] > PCR Bank: SHA256 [X] > PCR Bank: SHA384 [ ] > PCR Bank: SHA512 [ ] > [ ... ] > > Which looks correct to me (SHA1 bank present but not active). I see this also but when I get into Linux and run tpm2_pcrread I see the=20 SHA1 bank active but not having received any PCR extensions from the=20 firmware, which is not supposed to happen. So I think you should drop=20 this patch and I'll change the set of active PCR banks on the=20 swtpm_setup level. =C2=A0=C2=A0 Stefan > > take care, > Gerd >