From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E92112112FAB9 for ; Tue, 18 Sep 2018 04:23:46 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C320B86674; Tue, 18 Sep 2018 11:23:45 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-209.rdu2.redhat.com [10.10.120.209]) by smtp.corp.redhat.com (Postfix) with ESMTP id 51E09874F3; Tue, 18 Sep 2018 11:23:44 +0000 (UTC) To: Jiaxin Wu , edk2-devel@lists.01.org Cc: Ye Ting , Carsey Jaben , Fu Siyuan , Shao Ming References: <20180917054348.19228-1-Jiaxin.wu@intel.com> From: Laszlo Ersek Message-ID: Date: Tue, 18 Sep 2018 13:23:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180917054348.19228-1-Jiaxin.wu@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 18 Sep 2018 11:23:45 +0000 (UTC) Subject: Re: [Patch 0/5] Support windowsize to benefit tftp/pxe download performance. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Sep 2018 11:23:47 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/17/18 07:43, Jiaxin Wu wrote: > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=886 > > The series patches are to support the TFTP windowsize option described in RFC 7440. > TFTP shell command and UEFI PXE driver will use the feature to benefit the download > performance. I tested this series, between two virtual machines running on my laptop. The TFTP server program that I used was "tftp-server-5.2-22.el7.x86_64". The downloaded file was 478,150,656 bytes in size. I built OVMF with NETWORK_IP6_ENABLE, so that the last patch would take effect for both PXEv4 and PXEv6. Before the series: - PXEv4: 75 seconds (~ 6225 KB/s) - PXEv6: 100 seconds (~ 4669 KB/s) After the series: - PXEv4: 48 seconds (~ 9728 KB/s) - PXEv6: 60 seconds (~ 7782 KB/s) These measurements are very rough (I didn't run them multiple times etc), but I think they are still quite good indicators. For the testing, I used the UEFI boot options in UiApp, and not the shell command, hence I have no feedback on patch #3. For patches #1, #2, and #5: Tested-by: Laszlo Ersek However, as I pointed out elsewhere in the thread, I think: - You might want to port the changes from patch#5 to "MdeModulePkg/Universal/Network/UefiPxeBcDxe" as well, in a separate patch (patch #6). - If not, then (a) we should document this feature difference in the INF files of the UefiPxeBcDxe drivers, (b) patch #4 should be re-done so that it target NetworkPkg, not MdeModulePkg. - Patch #4 (regardless of package DEC) should be extended with documentation (both DEC and UNI). Thanks Laszlo