Re: [Patch 1/6] DynamicTablesPkg: Add missing BaseStackCheckLib instance

["Sami Mujawar" <sami.mujawar@arm.com>]

Hi Mike,

Thank you for this patch. These changes look good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar


On 03/11/2021 03:05 AM, Michael D Kinney wrote:
> Fix ARM and AARCH64 build issues by adding the BaseStackCheckLib
> instance.
>
> Cc: Sami Mujawar <Sami.Mujawar@arm.com>
> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>   DynamicTablesPkg/DynamicTablesPkg.dsc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/DynamicTablesPkg/DynamicTablesPkg.dsc b/DynamicTablesPkg/DynamicTablesPkg.dsc
> index 46b2e667fd25..e1439a130143 100644
> --- a/DynamicTablesPkg/DynamicTablesPkg.dsc
> +++ b/DynamicTablesPkg/DynamicTablesPkg.dsc
> @@ -35,6 +35,7 @@ [LibraryClasses]
>   
>   [LibraryClasses.ARM, LibraryClasses.AARCH64]
>     NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
> +  NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
>     PL011UartLib|ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf
>   
>   [Components.common]
> @@ -51,4 +52,3 @@ [BuildOptions]
>     # Inhibit C6305: Potential mismatch between sizeof and countof quantities.
>     *_VS2017_*_CC_FLAGS = /wd6305 /analyze
>   !endif
> -