public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
	Hao A Wu <hao.a.wu@intel.com>,
	Jian J Wang <jian.j.wang@intel.com>,
	Liming Gao <liming.gao@intel.com>,
	Michael Kubacki <michael.a.kubacki@intel.com>,
	Shenglei Zhang <shenglei.zhang@intel.com>,
	Xiaoyu Lu <xiaoyux.lu@intel.com>
Subject: Re: [PATCH 0/3] local header listing fixes for INF files, for edk2-stable201911
Date: Thu, 21 Nov 2019 17:07:07 +0100	[thread overview]
Message-ID: <bbf78542-f76b-6125-d698-aa459d83aaeb@redhat.com> (raw)
In-Reply-To: <20191121100053.GK7323@bivouac.eciton.net>

On 11/21/19 11:00, Leif Lindholm wrote:
> On Thu, Nov 21, 2019 at 10:38:30AM +0100, Laszlo Ersek wrote:
>> Repo:              https://github.com/lersek/edk2.git
>> Branch:            local_hdrs
>> Personal CI build: https://github.com/tianocore/edk2/pull/188
>>
>> I'm proposing this small set of fixes for edk2-stable201911.
>>
>> If the consensus is that they should be delayed until after
>> edk2-stable201911, I'm OK with that too.
> 
> For the series:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

Thanks!

> 
> But unless this addresses an actual build failure in some setup (and I
> don't see how it could), please defer until after stable tag.

Right, this only triggers warnings from "build", which are meant to be
informative. No build is actually broken, to my knowledge. So I'll
postpone pushing the series. (I still need pkg maintainer feedback anyway.)

Thanks!
Laszlo

> 
> Best Regards,
> 
> Leif
> 
>> Cc: Hao A Wu <hao.a.wu@intel.com>
>> Cc: Jian J Wang <jian.j.wang@intel.com>
>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>> Cc: Liming Gao <liming.gao@intel.com>
>> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
>> Cc: Shenglei Zhang <shenglei.zhang@intel.com>
>> Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
>>
>> Thanks
>> Laszlo
>>
>> Laszlo Ersek (3):
>>   MdeModulePkg/VariableSmmRuntimeDxe.inf: list local header "Variable.h"
>>   CryptoPkg/OpensslLib: improve INF file consistency
>>   CryptoPkg/OpensslLib.inf: list OpenSSL local header "ms/uplink.h"
>>
>>  CryptoPkg/Library/OpensslLib/OpensslLib.inf                          | 6 +++---
>>  MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf | 1 +
>>  2 files changed, 4 insertions(+), 3 deletions(-)
>>
>> -- 
>> 2.19.1.3.g30247aa5d201
>>
> 


  reply	other threads:[~2019-11-21 16:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-21  9:38 [PATCH 0/3] local header listing fixes for INF files, for edk2-stable201911 Laszlo Ersek
2019-11-21  9:38 ` [PATCH 1/3] MdeModulePkg/VariableSmmRuntimeDxe.inf: list local header "Variable.h" Laszlo Ersek
2019-11-21 15:53   ` [edk2-devel] " Philippe Mathieu-Daudé
2019-11-21 15:55   ` Wang, Jian J
2019-11-21  9:38 ` [PATCH 2/3] CryptoPkg/OpensslLib: improve INF file consistency Laszlo Ersek
2019-11-21 14:44   ` Wang, Jian J
2019-11-21 15:48   ` [edk2-devel] " Philippe Mathieu-Daudé
2019-11-21  9:38 ` [PATCH 3/3] CryptoPkg/OpensslLib.inf: list OpenSSL local header "ms/uplink.h" Laszlo Ersek
2019-11-21 14:43   ` [edk2-devel] " Wang, Jian J
2019-11-21 15:51   ` Philippe Mathieu-Daudé
2019-11-21 10:00 ` [PATCH 0/3] local header listing fixes for INF files, for edk2-stable201911 Leif Lindholm
2019-11-21 16:07   ` Laszlo Ersek [this message]
2019-12-02 20:23 ` [edk2-devel] " Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bbf78542-f76b-6125-d698-aa459d83aaeb@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox