public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: Shenglei Zhang <shenglei.zhang@intel.com>, devel@edk2.groups.io
Cc: Sean Brogan <sean.brogan@microsoft.com>,
	Bob Feng <bob.c.feng@intel.com>,
	Liming Gao <liming.gao@intel.com>
Subject: Re: [PATCH] .gitmodules: ignore untracked files in brotli
Date: Tue, 28 Apr 2020 14:52:25 +0200	[thread overview]
Message-ID: <bc0f122c-4ed5-119f-67ba-5de363a93d3d@redhat.com> (raw)
In-Reply-To: <20200427012051.5724-1-shenglei.zhang@intel.com>

On 04/27/20 03:20, Shenglei Zhang wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2692
> BrotliCompress submodule change for BaseTools causes untracked
> files in BaseTools after building. This is regression for git.
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  .gitmodules | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.gitmodules b/.gitmodules
> index 41099f6fd701..29370a5c2fe8 100644
> --- a/.gitmodules
> +++ b/.gitmodules
> @@ -16,3 +16,4 @@
>  [submodule "BaseTools/Source/C/BrotliCompress/brotli"]
>  	path = BaseTools/Source/C/BrotliCompress/brotli
>  	url = https://github.com/google/brotli
> +	ignore = untracked
> 

Looks plausible -- I haven't been aware of this setting, but it is
indeed documented in the gitmodules(5) manual.

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks!
Laszlo


      parent reply	other threads:[~2020-04-28 12:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-27  1:20 [PATCH] .gitmodules: ignore untracked files in brotli Zhang, Shenglei
2020-04-27 15:33 ` Liming Gao
2020-04-28 12:52 ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc0f122c-4ed5-119f-67ba-5de363a93d3d@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox