From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61])
 by mx.groups.io with SMTP id smtpd.web10.6592.1588078355692719280
 for <devel@edk2.groups.io>;
 Tue, 28 Apr 2020 05:52:35 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PVqgJnAP;
 spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1588078354;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ldh45etC1R6VTXCF7odiUGECa/j1S4yW9JYP9LBVGlA=;
	b=PVqgJnAPpGGiXoJJ0IcFy7Q8jauopfLsFYkDcWkfriLXWDAPf39JSEO9SoAZ1pFs54CoRK
	fl0F4wryf5/Jv+INxLO5Xrd4sxidRbi402CjYOp5h0c+dfmU46/973q51b264/R2mmVrje
	1pZlR3+gNnOZ+oU6pJamc4ZSfycOCQM=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-2-7omduJ55OJ6mCbAs9kNVig-1; Tue, 28 Apr 2020 08:52:29 -0400
X-MC-Unique: 7omduJ55OJ6mCbAs9kNVig-1
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F37071895A28;
	Tue, 28 Apr 2020 12:52:27 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-33.ams2.redhat.com [10.36.113.33])
	by smtp.corp.redhat.com (Postfix) with ESMTP id C81AC1002394;
	Tue, 28 Apr 2020 12:52:26 +0000 (UTC)
Subject: Re: [PATCH] .gitmodules: ignore untracked files in brotli
To: Shenglei Zhang <shenglei.zhang@intel.com>, devel@edk2.groups.io
Cc: Sean Brogan <sean.brogan@microsoft.com>, Bob Feng <bob.c.feng@intel.com>,
 Liming Gao <liming.gao@intel.com>
References: <20200427012051.5724-1-shenglei.zhang@intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <bc0f122c-4ed5-119f-67ba-5de363a93d3d@redhat.com>
Date: Tue, 28 Apr 2020 14:52:25 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20200427012051.5724-1-shenglei.zhang@intel.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

On 04/27/20 03:20, Shenglei Zhang wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2692
> BrotliCompress submodule change for BaseTools causes untracked
> files in BaseTools after building. This is regression for git.
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  .gitmodules | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.gitmodules b/.gitmodules
> index 41099f6fd701..29370a5c2fe8 100644
> --- a/.gitmodules
> +++ b/.gitmodules
> @@ -16,3 +16,4 @@
>  [submodule "BaseTools/Source/C/BrotliCompress/brotli"]
>  	path = BaseTools/Source/C/BrotliCompress/brotli
>  	url = https://github.com/google/brotli
> +	ignore = untracked
> 

Looks plausible -- I haven't been aware of this setting, but it is
indeed documented in the gitmodules(5) manual.

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks!
Laszlo