From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1F13BAC152C for ; Tue, 24 Oct 2023 12:45:18 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=GoeSuqfMGXBHziOx4DMw8aEolhDwHt9ZmLDcq1405RQ=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698151517; v=1; b=iww5EP9Kl/DAlpoqYOHIE/sdcv7ckC3nErawQ4By4XhbXHPUtgiWhw1cl1nwkhceCBW2JxQ/ dE7IuHWrhWKVJkTeWR7w9T4iUQullrUZEcyPXail/AjDhqSoLRb9fpwwD4WcpFJ5R2JDnS8g+Mn oeA0YZjowkbkkwNOETSnVDZw= X-Received: by 127.0.0.2 with SMTP id pB8kYY7687511x94x6S2ZeKG; Tue, 24 Oct 2023 05:45:17 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.17005.1698151516798999186 for ; Tue, 24 Oct 2023 05:45:16 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-452-LZ5kihP4NRaneuEIeMseVQ-1; Tue, 24 Oct 2023 08:45:11 -0400 X-MC-Unique: LZ5kihP4NRaneuEIeMseVQ-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 298FD80F8F6; Tue, 24 Oct 2023 12:45:10 +0000 (UTC) X-Received: from [10.39.195.39] (unknown [10.39.195.39]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 88B331121318; Tue, 24 Oct 2023 12:45:08 +0000 (UTC) Message-ID: Date: Tue, 24 Oct 2023 14:45:06 +0200 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v6 5/5] OvmfPkg/RiscVVirt: Override for RV CPU Features To: devel@edk2.groups.io, dhaval@rivosinc.com Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann , Sunil V L , Andrei Warkentin References: <20231021173314.19363-1-dhaval@rivosinc.com> <20231021173314.19363-6-dhaval@rivosinc.com> From: "Laszlo Ersek" In-Reply-To: <20231021173314.19363-6-dhaval@rivosinc.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: zpBBJ7P2VjbrhD8I4wfy789zx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=iww5EP9K; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 10/21/23 19:33, Dhaval Sharma wrote: > This PCD provides a way for platform to override any > HW features that are default enabled by previous stages > of FW (like OpenSBI). For the case where previous/prev > stage has disabled the feature, this override is not > useful and its usage should be avoided. >=20 > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann > Cc: Sunil V L > Cc: Andrei Warkentin > Cc: Laszlo Ersek >=20 > Signed-off-by: Dhaval Sharma > --- >=20 > Notes: > v2: > - Modify PCD name according to changes made in Baselib implementation > V1: > - Introduce PCD for platform >=20 > OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc b/OvmfPkg/RiscVVirt/Risc= VVirt.dsc.inc > index fe320525153f..5d66f7fe6ae6 100644 > --- a/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc > +++ b/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc > @@ -203,6 +203,7 @@ [PcdsFeatureFlag] > gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|TRUE > =20 > [PcdsFixedAtBuild.common] > + gEfiMdePkgTokenSpaceGuid.PcdRiscVFeatureOverride|0 > gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1000000 > gEfiMdePkgTokenSpaceGuid.PcdMaximumAsciiStringLength|1000000 > gEfiMdePkgTokenSpaceGuid.PcdMaximumLinkedListLength|0 I propose to only clear the least significant bit in the PCD -- that is, say 0xFFFFFFFFFFFFFFFE here. But, it's up to you. Either way: Acked-by: Laszlo Ersek -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110004): https://edk2.groups.io/g/devel/message/110004 Mute This Topic: https://groups.io/mt/102103786/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-