From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by mx.groups.io with SMTP id smtpd.web09.13617.1604064491174431799 for ; Fri, 30 Oct 2020 06:28:11 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=EUjm9VrI; spf=pass (domain: nuviainc.com, ip: 209.85.210.68, mailfrom: rebecca@nuviainc.com) Received: by mail-ot1-f68.google.com with SMTP id k3so5536636otp.1 for ; Fri, 30 Oct 2020 06:28:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=aTjPCJe4XajaeNdvWYtBOHrCSqrMqsUiDugW524PnU8=; b=EUjm9VrIj5YAjkLWk4lyUKM1GRjFcwnjpYlyFl4Fffi1r0BRJs2TnALC45cEEw0xlC W0MdoUpUD3gHRkbEXcw5pfKPi24bDMf2PMrAWCIU1Gpr/LnPnO5x3koR0sBZNTN9vuzZ uUQahzlzXzQDR6nTjmZsk6gsRvGTvFUlygZGgLwbqtXxqSpxiq3yUEFwjg+1WE0Ho9zn d4WE7Uu8GfsjKVkI20S6El0JHHMjD3023oiUof2LwpfDyejifZG6WLCt5hZliipejiTn bjieBPcymeJAMpabRyhDAPek5J7y13YDIpMJ/zmz0mqxn8PZgVenuGOuOiVisG69Dfr+ onkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=aTjPCJe4XajaeNdvWYtBOHrCSqrMqsUiDugW524PnU8=; b=aCg1TlfE0CWLc6C73U2+4mD+SkE/ZE0K47n9N0VHe7l8Kj4b9Xwh9r6gWqY/rZfWjS WYLFmc2/gobVQv/oRUNU6fgNZ03Eb/3DDKqVW995uxkPH3j2LlfCnJwZu29JU+KfUxmv T2zOY52Q3Q8hWE2hInzg7ujI/ChaftGoXpSGyj4KA/Yv/2CW1t5EetNTauKWTcIHgRSc VQtHD7sBT2lK+NOj5kMod3qMJ4rZxG58xfe7WhNbGlnkZK+Fi7JlNxAJVMHfPXvpIgMn 0mqvOTtVFDRJhDsX9BzGxLVvtULORmKyLZOyFq7zmzseyN6+LYm9k5adRp45zuzjOypu KaTQ== X-Gm-Message-State: AOAM532z6/49tVPoRDll4BNzMKJkC/hn1mGLJxwmhnKtLe4XnaFVwE/L pl/YTtc1EOF3rqpSFzOJFzDijA== X-Google-Smtp-Source: ABdhPJz1ZZEwsJXV/TPYwiFFcEE2sXT69/7FNHxH5JKcLZ8Egtn/m2/eEyIU42pFkfOM5xefX13X5w== X-Received: by 2002:a9d:731a:: with SMTP id e26mr1604551otk.159.1604064490567; Fri, 30 Oct 2020 06:28:10 -0700 (PDT) Return-Path: Received: from [10.0.10.142] (muon.bluestop.org. [65.103.231.193]) by smtp.gmail.com with ESMTPSA id r8sm1267541otq.43.2020.10.30.06.28.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Oct 2020 06:28:09 -0700 (PDT) Subject: Re: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition To: "Gao, Zhichao" , "devel@edk2.groups.io" Cc: "Kinney, Michael D" , Liming Gao , "Liu, Zhiguang" , "Ni, Ray" References: <20201027172931.27297-1-rebecca@nuviainc.com> From: "Rebecca Cran" Message-ID: Date: Fri, 30 Oct 2020 07:28:08 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Thanks - I'll try and remember to do that in future. -- Rebecca Cran On 10/29/20 7:08 PM, Gao, Zhichao wrote: > The patch 1-4 are same with V1. If there is no change with previous patches and the patches are already reviewed. You should add the Reviewed-by for the reviewed patches. That would avoid Maintainers/Reviewers to review the patches again. And it is suggested to add the change info in the cover-letter. > Keep my RB for 1-4. I am OK with patch #5: Reviewed-by: Zhichao Gao > > Thanks, > Zhichao > >> -----Original Message----- >> From: Rebecca Cran >> Sent: Wednesday, October 28, 2020 1:29 AM >> To: devel@edk2.groups.io >> Cc: Rebecca Cran ; Kinney, Michael D >> ; Liming Gao ; Liu, >> Zhiguang ; Ni, Ray ; Gao, Zhichao >> >> Subject: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 >> ARM64 SoC ID definition >> >> Fix some typos in smbiosview. >> >> Add the SMC ARM64 SoC ID supported bit from SMBIOS 3.4.0 to SmBios.h and >> smbiosview. >> >> Fix the type of the PROCESSOR_CHARACTERISTIC_FLAGS bitfield. >> >> Pull request: https://github.com/tianocore/edk2/pull/1052 >> >> Rebecca Cran (5): >> ShellPkg: Fix a couple of typos in smbiosview >> ShellPkg: Fix smbiosview string definition name for "boot from CD" >> ShellPkg: Add ARM64 SoC ID to Processor Characteristics in smbiosview >> MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field >> MdePkg: Fix SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS to be UINT16 >> >> MdePkg/Include/IndustryStandard/SmBios.h | 21 ++++++++++--------- >> .../SmbiosView/PrintInfo.c | 2 +- >> .../SmbiosView/QueryTable.c | 4 ++++ >> .../SmbiosView/SmbiosViewStrings.uni | 4 ++-- >> 4 files changed, 18 insertions(+), 13 deletions(-) >> >> -- >> 2.26.2