From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.97]) by mx.groups.io with SMTP id smtpd.web11.9862.1683698353775075971 for ; Tue, 09 May 2023 22:59:14 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="no key for verify" header.i=@amperemail.onmicrosoft.com header.s=selector1-amperemail-onmicrosoft-com header.b=jsmUuTXU; spf=pass (domain: os.amperecomputing.com, ip: 40.107.94.97, mailfrom: nhi@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UHcj2+3++QsGTkYyy86OX0bxHZBzbXc5H2Uul13oJe/D54W9BRuaMgHmXnrgTEwnN3dYBvtXUMo0cqVSdwBbOT+/MxUP8DJQtnxBYYaI9tabF4IL1srdPOJMWgVLh01U8RXXxtHvrn/oEJnrPMgO/60GXqZvcWC3ZEG7TnkE89cegk/GgFLwD8EukW7jQwo/kDXQHEIw99mCAg3putEzEr22Qkip/wmO/idKPRF3mJaWh4ciCLrjg5UX838q5fK3ch6136JNCI9G6UDCAucsilW9RRNs84p1NBh2ygYPxXCKkzAoMJmH90kx+5xVgmlHHTct3j5etfV/iF9RjduScg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P4lpIiGG33Q/oYmYp1tmPNFAIsL8ufV7FRiN7lVZLvg=; b=Dsm9Yecp94v5n36WXBGiHyPUeID6KqEkfNHe5s66o4j2kLW6fDYYdQGQLGwCHWp16oOYlZvjIRn2/5l+2np7D+LW6RQtDbeB4GzcnOouJRDQ5/Ap8FyePuw3Mextznie/IUs8L1U7KNnS2gtQ45oBrZBto292rk1DEoBr4LXFvr4qmtw2lUUKZ1jOSTtnY3Eb77CJKEgVAs0ZZKHILdBUlNWJcr8nDdAsYE+xOnJv85DlhEqaO/J6tj4MIBX74j7t0ykshjnToOiUACHBfil1QEbEVygYmeHPGbe3JEpvussLYoZxLrO7H+YKh4C2SVDKJtt1mZGq0++NULP6UKQ0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=amperemail.onmicrosoft.com; dkim=pass header.d=amperemail.onmicrosoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amperemail.onmicrosoft.com; s=selector1-amperemail-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P4lpIiGG33Q/oYmYp1tmPNFAIsL8ufV7FRiN7lVZLvg=; b=jsmUuTXU0nHm06X2bePGIGps2fk9IqTsRjoik8x+RpQ2m7oveHAN8ygmLcar1GRfrPtzCIV5bZDmcQTF90AfRt2i9UyU9hSCqkk5T/U4lV3CZyEe8IldZpwPjpQ6gDpTLU5nvAPNEdFhaXWrP6wsNNnlM4HJczFwexAMFo9/6GQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amperemail.onmicrosoft.com; Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by SN6PR01MB3935.prod.exchangelabs.com (2603:10b6:805:1c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Wed, 10 May 2023 05:59:10 +0000 Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::8b9f:c392:42fb:e468]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::8b9f:c392:42fb:e468%5]) with mapi id 15.20.6363.033; Wed, 10 May 2023 05:59:09 +0000 Message-ID: Date: Wed, 10 May 2023 12:59:00 +0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [edk2-devel][edk2-platforms][PATCH 0/2] Support for PCIe Auto Bifurcation feature To: Minh Nguyen , quic_llindhol@quicinc.com, ardb+tianocore@kernel.org Cc: devel@edk2.groups.io, patches@amperecomputing.com, thang@os.amperecomputing.com, nhi@os.amperecomputing.com, tinhnguyen@os.amperecomputing.com References: <20230505024918.1447433-1-minhnguyen1@os.amperecomputing.com> From: "Nhi Pham" In-Reply-To: <20230505024918.1447433-1-minhnguyen1@os.amperecomputing.com> X-ClientProxiedBy: SI2PR01CA0002.apcprd01.prod.exchangelabs.com (2603:1096:4:191::21) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) Return-Path: nhi@os.amperecomputing.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB7287:EE_|SN6PR01MB3935:EE_ X-MS-Office365-Filtering-Correlation-Id: 2c2c19a0-6ef8-4f71-8f42-08db511babca X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LRuuUqRruq/maVIVKTHCHZv3DlbwAYykvXJSnOW7T2tz/QeVKssl9GiQWAH5pS+Ot1fwjzbzE14dNKOawuFQ1SH2SswANgrM1tqKHNdf3Gxcb7T97vxqTbGtBSCxkuCGGrwutKOQ+V6zqUIJi75Rs61UY5T6aZoHcdpAztOy6SOgzrYMaQijYFgbw25j4F9Q75wIkiDBgpG0uYyO8QyuAsTEHo7mRUNIxqtbIW+TE7KRqd6xtopE6el0LIsxitOxby0pC8pFmRsFvqDVp19u2Iv41SaCeMqgWhvp+eVvGtyGWObRqMXhUna6YVz7fqL2ciZRwEEfVXgCQPGYxyAwQf5I803yapwUQJHwfsoacCCW/gL7qNa3pppDNS/zcSznfLSh7oosCfE7mTd9aEG7BoSLSsVU/61BCQ+FRRhcfUzCf+xWxpkP7bLh8gmdu1Og+fFLxMKNMbZjaq0zH6RRwwJIp/3v0TN52Tbo+KqE7kr1E5F9dJ7ayoU2uKgOm0HAeXUSLSVV4/Nnw0XgH+xPEI6EG0GC8N0B4XfgsfmmDKNxjU4Yy283IJH/Qe4goj86uIKxqq4Tk1L6zIsBcIazKB2DMZXsggqGT1Uvi0GuQItwUaTIMuoEznuuOHPDSJND X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR01MB7287.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(366004)(39850400004)(376002)(346002)(136003)(451199021)(5660300002)(31686004)(6486002)(8936002)(6666004)(41300700001)(316002)(8676002)(26005)(53546011)(66476007)(478600001)(66556008)(66946007)(6512007)(6506007)(107886003)(4326008)(2906002)(83380400001)(42882007)(186003)(2616005)(83170400001)(31696002)(38100700002)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VkdFWVNCRkJiMExKc0FwdVZ1UlIzY3FudTNsRGFxVTlCMFMzdldhbzFRN2wz?= =?utf-8?B?N0RyZUsydnNhZ1VnbTFJeitZYWhMOXp1MmFUYzlaZ3daNENrUjAvNWNYdjZG?= =?utf-8?B?UzczZW14a1A0Nnd5dkswS3ZPbXFHdWdwZ3BaR2hNS3VpdEdwTDl5QjFSdVpC?= =?utf-8?B?RE9yUWp2a3NMWTVWOEZrZDA4TGs4OFEzaUJwU0hDdTE3VklMS0hDck1vY2hJ?= =?utf-8?B?RXVhdnNKeEdBVE9OQ1hjZWlzVlZiaTB1VjhzY29DT0ptdnJHZStPWW9sWEF0?= =?utf-8?B?d2dyOU1qQlRVVnd5anpocjhrOXhRZ3lCTDFCTU0ycU02aXBGL3p3T0VFYmMv?= =?utf-8?B?M1NwbG01d1Mzd1h5OGw1L2FqVHZCZ2VQQS94REgvWWFrbzlPa2VMQzBqVjlv?= =?utf-8?B?dGlMamE5WVpzbTA1Wm1kaVh6dnUrUWlGZU9GUk4xVmFudFZqMzZSZDBENmNP?= =?utf-8?B?QVAyTEgyZG5SQ3JxOWp6akd4SVQwVi9zaDR4VG5yVTM3czBiT1dYL1gvd0JW?= =?utf-8?B?T2JLa0V0Y0NPYnkxYjNtNFQyanpDcWczcVFLamF6YmRySkF3cVJIbTh0dG5l?= =?utf-8?B?VnJJdkZQWlJqc1NBdFkvNlVpNW9SMlJrUVc1NTkyY3phSG56T1ZDeHk4L25W?= =?utf-8?B?eGpDWGlLVGF1OFF0dEVmTTFiSmkrZkdodHB4cmpPYkVmeUxWOUdaNWt6VXl5?= =?utf-8?B?djJYeUdjb3ZpclJobXpMVlpoL0VtS0krKzFpL2haSkh3SnB5SVNPZ2VPOTVE?= =?utf-8?B?QndxNE5wWmlLSEtVMHhJOFVBRXladXlDM2NneWNCVktJWWx6N0lmQnVZM0dF?= =?utf-8?B?N3VndkRtVmFWMmNSalp5WTRUR2JLZmczUXFGdFdzRm01WmFWSUxucDZtWGpR?= =?utf-8?B?d0JlMHhuUmE2d2RQTTBhWFZ4VkVjYVQrRU5ENWU4dXF5NlU1Ykd3OVJVeFpm?= =?utf-8?B?a2JLT3dINE85eHorY2phREx5ZHcrUzlTT1JaWGJJRkJScmh0QXFwVnhlS2l0?= =?utf-8?B?QUZkUXhjMXV5OVFBNi9UNGYrcGFuSW1TVDZMWVp6QUprN1RVN3JNSzJ0KzZC?= =?utf-8?B?cnBTVkswR2pGVWVqSy9qcXluUDhEZ0Urd1dXVWFHSGlWbktqb21MMXdxZS9H?= =?utf-8?B?ZmgrVFBXYk1RTkQzNXBmaGxnYWFhOHViZzZYY1hKU0VvVzRPcFExMlp1TVpk?= =?utf-8?B?WlBxdllBQjlTU21TSk9vd25qaHdtRkQ5NFNQK3VaUEsxcUhHaWhveStFUUY2?= =?utf-8?B?NjZwb29TVUkvRllmWTRtVHI3NWlhazF4L3VZQlJuRy9rWE9ybmNNc0M3Q1ZW?= =?utf-8?B?Njl4U25YTC8wQW5wV3BNY1UrNjdFSUJRdkZobmMxck4xRktFdkNpYkROV0E0?= =?utf-8?B?UVAybUtCRWZkR3VmSFYrb3IwNGhtNmpBdzFsckxSWTA0bGU2dXdEckNWS0py?= =?utf-8?B?bzJmT0piWko1UGdUTEZXa21NSU50N2FCMGU4SG1LTXhHd3U5bndqV0ZHSVNp?= =?utf-8?B?cmNQNTZmeTBubDZoK3hTTzdvVE54ZDN3eG53M1psb2RlQ3VUK3c0QWoyWlBy?= =?utf-8?B?Y1FNOE1JSjhLRXBxdnJUd3BuY0xRMjdpS1pkcFl4OEhZLzNOcHRwWDVLZm1N?= =?utf-8?B?RnZVakJNaXF0OHNyaG9LaHR6YXhwT01NKzFvVmVFYTZOcHc4S3dCYXFxOFRB?= =?utf-8?B?eERvd2lBc095aGFjTEhkeldtOThBUmdOTlpkR2E4UWJOc1RxWUVlN21NTHRI?= =?utf-8?B?bkJKRXJEU25ZSks0TVF1eDJNTkk3TEo3WC8xS3pJaXQyM3NOREZPc1hEcy8y?= =?utf-8?B?bGVKakdSNEoyV0VidzNwdWVDL29IZkpzQVQ4cnkyZ2tnSlhRNGVOelpManVK?= =?utf-8?B?UU5tZnFrK2lnTXdSSVIwYjJBeUQxc004dlE2QXJjdEQ0SUE5VVkrdHBkZFRq?= =?utf-8?B?c2NSK0NIcU8vc0M3ZE1FcVRqMmhhQUZBYkVZYjBHYlN6SjBVdHlnMnNGNXFo?= =?utf-8?B?eittcnA4YzlDT2tEMk9HSkdFNTR3SU8xYWwvdkhQM1pJRmdlMHZmMjV6Z1Qr?= =?utf-8?B?TFAvTk4rMjVvNFdTNHJvNGhpd09DSVpXUjgwYy9qQy9jb2EwMHdyTDhpRGp2?= =?utf-8?B?R204amUvcXdaRitpelFSQzMxSGhpSmw5SnRvYThIMVJGaEpkc29hcjkzYjkx?= =?utf-8?Q?Y/8nO3jGJmNRhoGi8zyti+U=3D?= X-OriginatorOrg: amperemail.onmicrosoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c2c19a0-6ef8-4f71-8f42-08db511babca X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2023 05:59:09.5721 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8ird6asf2yJVccWbaZ/dWF22UexFPphz0Lj9JyDR+lonw+ngC/kg/dvglIXlrky4/c9wENs6uEHJypV/ADO/VWj3xG2tHGpwQBOz6U2Zm4M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR01MB3935 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Thanks Minh for this series. It looks good to me. Reviewed-by: Nhi Pham Hi Leif, Ard - Could you please help merge this series? Thanks, Nhi On 5/5/2023 9:49 AM, Minh Nguyen wrote: > These patches support for PCIe Auto Bifurcation feature of Ampere > silicon (Altra and Altra Max). > > Vu Nguyen (2): > AmpereAltraPkg: Add support for PCIe Auto Bifurcation > AmpereAltraPkg: Enable auto bifurcation via BoardSetting > > Silicon/Ampere/AmpereAltraPkg/Drivers/PcieInitPei/RootComplexNVParam.h | 4 +- > Silicon/Ampere/AmpereAltraPkg/Include/Guid/RootComplexInfoHob.h | 5 +- > Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.h | 5 + > Silicon/Ampere/AmpereAltraPkg/Drivers/PcieInitPei/RootComplexNVParam.c | 14 +- > Silicon/Ampere/AmpereAltraPkg/Drivers/RootComplexConfigDxe/RootComplexConfigDxe.c | 19 +- > Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c | 344 +++++++++++++++++++- > Silicon/Ampere/AmpereAltraPkg/Drivers/RootComplexConfigDxe/RootComplexConfigDxe.uni | 3 +- > 7 files changed, 383 insertions(+), 11 deletions(-) >