From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 85C8B21D49188 for ; Thu, 10 Aug 2017 12:45:58 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C39382EA34A; Thu, 10 Aug 2017 19:48:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C39382EA34A Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-96.phx2.redhat.com [10.3.116.96]) by smtp.corp.redhat.com (Postfix) with ESMTP id 331B917CEB; Thu, 10 Aug 2017 19:48:17 +0000 (UTC) To: Jordan Justen , edk2-devel@lists.01.org References: <1501776600-16369-1-git-send-email-brijesh.singh@amd.com> <1501776600-16369-2-git-send-email-brijesh.singh@amd.com> <2517ecce-c92c-b85c-39a7-f454048e6b3d@redhat.com> <2b7e7cfb-0006-9dc2-951f-2d1f7d1a3214@redhat.com> <150186651004.27627.8056916076752739657@jljusten-skl> <150239020750.4777.16972339809591983854@jljusten-skl> From: Laszlo Ersek Message-ID: Date: Thu, 10 Aug 2017 21:48:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <150239020750.4777.16972339809591983854@jljusten-skl> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 10 Aug 2017 19:48:17 +0000 (UTC) Subject: Re: [PATCH v2 1/1] OvmfPkg : QemuFwCfgLib: Use BusMasterCommandBuffer to map FW_CFG_DMA_ACCESS X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Aug 2017 19:45:58 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/10/17 20:36, Jordan Justen wrote: > On 2017-08-04 13:25:09, Laszlo Ersek wrote: >>> >>> I have another reason why going beyond 80 is not a good idea for code >>> that doesn't apply to normal reading. If you need ~120 columns visible >>> to view some lines, then most lines will end up having a lot of wasted >>> horizontal whitespace because they can commonly fit into 80 columns. >> >> One reason I dislike the "all arguments on separate lines" rule is just >> this -- it wastes perfectly good horizontal space, and eats up precious >> vertical space. >> >> We have a patch submission process for our documents now, > > I think I agree about the multiple args/multiple lines issue. I guess > you could try to submit a code style doc change, but I'm not sure how > controversial it might be. > >> but I don't >> think maintainers of other Pkgs would bother with following and >> enforcing a stricter 80 columns rule, even if we got it codified. :/ > > I still think we should have it written stricter even if it isn't > always followed. It could be a step in the right direction. OK, I'm tagging this for later... Not sure how much later ;) Thanks Laszlo