public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Jaben Carsey <jaben.carsey@intel.com>
To: edk2-devel@lists.01.org
Cc: Yonghong Zhu <yonghong.zhu@intel.com>, Liming Gao <liming.gao@intel.com>
Subject: [PATCH v1 2/4] BaseTools: use in to compare single chars
Date: Wed, 28 Mar 2018 17:02:18 -0700	[thread overview]
Message-ID: <bc1fce9b4f8685571b049c45289e4fc3c91abe54.1522281624.git.jaben.carsey@intel.com> (raw)
In-Reply-To: <cover.1522281624.git.jaben.carsey@intel.com>
In-Reply-To: <cover.1522281624.git.jaben.carsey@intel.com>

instead if 3 Startswith for single chars, just use in with a list of chars

Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
---
 BaseTools/Source/Python/Common/Expression.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Source/Python/Common/Expression.py b/BaseTools/Source/Python/Common/Expression.py
index 4a3dea1190b2..51f83ad4c7a4 100644
--- a/BaseTools/Source/Python/Common/Expression.py
+++ b/BaseTools/Source/Python/Common/Expression.py
@@ -835,7 +835,7 @@ class ValueExpressionEx(ValueExpression):
                         elif Item.startswith('UINT64'):
                             ItemSize = 8
                             ValueType = 'UINT64'
-                        elif Item.startswith('"') or Item.startswith("'") or Item.startswith('L'):
+                        elif Item[0] in ['"',"'",'L']:
                             ItemSize = 0
                             ValueType = 'VOID*'
                         else:
-- 
2.16.2.windows.1



  parent reply	other threads:[~2018-03-28 23:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-29  0:02 [PATCH v1 0/4] BaseTools: eliminate some redundant code Jaben Carsey
2018-03-29  0:02 ` [PATCH v1 1/4] BaseTools: no need to do int() API work for it Jaben Carsey
2018-03-29  0:02 ` Jaben Carsey [this message]
2018-03-29  0:02 ` [PATCH v1 3/4] BaseTools: remove loop and variables Jaben Carsey
2018-03-29  0:02 ` [PATCH v1 4/4] BaseTools: cleanup class heirarchy Jaben Carsey
2018-03-30  1:12 ` [PATCH v1 0/4] BaseTools: eliminate some redundant code Zhu, Yonghong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc1fce9b4f8685571b049c45289e4fc3c91abe54.1522281624.git.jaben.carsey@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox