From: Pete Batard <pete@akeo.ie>
To: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH 6/6] BaseTools/Conf: Add VS2017/ARM support
Date: Mon, 4 Dec 2017 17:43:39 +0000 [thread overview]
Message-ID: <bc3466e2-1667-7b38-ef45-4c9a740870a6@akeo.ie> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E189D15@SHSMSX104.ccr.corp.intel.com>
On 2017.12.04 15:48, Gao, Liming wrote:
> 1. You add new build for ARM. I remember the reason is that --convert-hex can't be used by trim for ARM ASM file. Right?
That is correct.
Maybe there's a better option to achieve just that, as duplicating the
whole section just to remove an option seems a bit of an overkill...
> 2. On tools_def.txt. Why introduce /D_ARM_WINAPI_PARTITION_DESKTOP_SDK_AVAILABLE option?
The MSFT toolchain for ARM actively prevents compilation of native
applications, when using Microsoft headers, unless this value is
defined. If that is not the case, you get the error: "Compiling Desktop
applications for the ARM platform is not supported."
So this was needed when we were still using Microsoft headers for
stdarg.h, as compilation would break otherwise.
However, now that we are no longer relying on any standard headers from
the VS toolchain, I just confirmed that the option is no longer needed
(as the check for this definition is done in one of the Microsoft
headers, not the compiler).
I will therefore remove that option, as it is no longer needed.
Regards,
/Pete
prev parent reply other threads:[~2017-12-04 17:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 13:11 [PATCH 0/6] Add ARM support for VS2017 Pete Batard
2017-12-04 13:12 ` [PATCH 1/6] MdePkg: Disable some Level 4 warnings for VS2017/ARM Pete Batard
2017-12-04 15:36 ` Gao, Liming
2017-12-04 17:42 ` Pete Batard
2017-12-04 13:12 ` [PATCH 2/6] MdePkg/Library/BaseStackCheckLib: Add Null handler " Pete Batard
2017-12-04 13:12 ` [PATCH 3/6] MdePkg/Library/BaseLib: Enable VS2017/ARM builds Pete Batard
2017-12-04 15:40 ` Gao, Liming
2017-12-04 17:43 ` Pete Batard
2017-12-04 13:12 ` [PATCH 4/6] ArmPkg/Library/CompilerIntrinsicsLib: " Pete Batard
2017-12-04 13:12 ` [PATCH 5/6] MdePkg/Include: Add VA list support for VS2017/ARM Pete Batard
2017-12-04 13:12 ` [PATCH 6/6] BaseTools/Conf: Add VS2017/ARM support Pete Batard
2017-12-04 15:48 ` Gao, Liming
2017-12-04 17:43 ` Pete Batard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc3466e2-1667-7b38-ef45-4c9a740870a6@akeo.ie \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox