From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web12.4928.1622110599431632121 for ; Thu, 27 May 2021 03:16:39 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SPJrYpj2; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622110598; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3LR14mD9etJdTyvgOVZ24mBg6WOxfmN3kzPe0qeE/XM=; b=SPJrYpj21nPwg+tPx84A7R8VQROP/HgzhtJ3Vvyef8cylk2+Iw0HQ7XMaYwB/bn1S2RbVg GBgn6HoAFfIURDbQHK/jDZo7xmOsX/+ufs0SoE8+aLfpMgXDjfQ2EkTGqwWlPRgx/gExTc aT/ryN0cfuLaGUXy9Oiixiqm5iql3qI= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-141-N7AmaGlHPiiHGMmzM3i6pw-1; Thu, 27 May 2021 06:16:36 -0400 X-MC-Unique: N7AmaGlHPiiHGMmzM3i6pw-1 Received: by mail-wr1-f70.google.com with SMTP id q15-20020adfc50f0000b0290111f48b865cso1563455wrf.4 for ; Thu, 27 May 2021 03:16:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3LR14mD9etJdTyvgOVZ24mBg6WOxfmN3kzPe0qeE/XM=; b=B6riahRgT7U7PPYlM8rNZzysspUHkgTxhBU02hzI3y+yeN0YqyLyJYuLnS0o4F76UX 1/vvjBVZMIGhowU1GdCYUDaoTPDoql7ZEj+6e0LlT8plgky8rJo4TcVzOQjrlUI5IpF3 5+k+T9dRJWafD0jxyg2VjXRBhTpI0zGbilgERNC9ALh9v2F1PSMbHdrVdRSUloegwNon hno6Ky8ZcLgWEF+o4I8/72l2f2N+nf/w6fhKWm5FGl9i/oZg98IYi1p1xeEsRkoLaMu3 Q8HAlPppXQONeESOs+xSDkqtMTXzGAHBwAfZP8rm2CjxBNXri6CZaYXamMqcquRcKoKB AZhw== X-Gm-Message-State: AOAM533cqALuElpmIe1xHAVgVijkCoa4MB1LnE35XUK8EXhRrTkXB66a h47HgWPXCPFd62QhJfTpTagQWeLNRsohCGqOVPmVIzXduXap1Phh+jvW24BNvGUiOw5+SRNrcMN j05BWn8s8075e7Q== X-Received: by 2002:a7b:ca58:: with SMTP id m24mr7620601wml.151.1622110595449; Thu, 27 May 2021 03:16:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwEsW76M2vIRpuvV3+rTlnEbzOwZlTh+FKAI6lV0O49gd4CXKwzjOPr592wGY7Ati6TpWZ5sw== X-Received: by 2002:a7b:ca58:: with SMTP id m24mr7620581wml.151.1622110595163; Thu, 27 May 2021 03:16:35 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (235.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.235]) by smtp.gmail.com with ESMTPSA id r17sm10543185wmh.25.2021.05.27.03.16.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 May 2021 03:16:34 -0700 (PDT) Subject: Re: [PATCH 11/43] OvmfPkg/XenAcpiPlatformDxe: create from AcpiPlatformDxe To: Laszlo Ersek , devel@edk2.groups.io Cc: Andrew Fish , Anthony Perard , Ard Biesheuvel , Jordan Justen , Julien Grall , Leif Lindholm , Michael D Kinney References: <20210526201446.12554-1-lersek@redhat.com> <20210526201446.12554-12-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Thu, 27 May 2021 12:16:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210526201446.12554-12-lersek@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 5/26/21 10:14 PM, Laszlo Ersek wrote: > Create an almost verbatim copy of the > "OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf" driver for the OvmfXen > platform. We're going to trim the driver in subsequent patches. > Ultimately, the XenAcpiPlatformDxe driver will duplicate a negligible > amount of code that is currently present in the QemuFwCfgAcpiPlatformDxe > driver. > > List the new driver in "Maintainers.txt", in the "OvmfPkg: Xen-related > modules" section. > > Switch the OvmfXen platform to the new driver at once. > > This patch should be reviewed with "git show --find-copies-harder". > > Cc: Andrew Fish > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/OvmfXen.dsc | 2 +- > OvmfPkg/OvmfXen.fdf | 2 +- > OvmfPkg/{AcpiPlatformDxe/AcpiPlatformDxe.inf => XenAcpiPlatformDxe/XenAcpiPlatformDxe.inf} | 7 ++++--- > Maintainers.txt | 1 + > OvmfPkg/{AcpiPlatformDxe => XenAcpiPlatformDxe}/AcpiPlatform.h | 3 ++- > OvmfPkg/{AcpiPlatformDxe => XenAcpiPlatformDxe}/AcpiPlatform.c | 3 ++- > OvmfPkg/{AcpiPlatformDxe => XenAcpiPlatformDxe}/BootScript.c | 2 +- > OvmfPkg/{AcpiPlatformDxe => XenAcpiPlatformDxe}/EntryPoint.c | 4 ++-- > OvmfPkg/{AcpiPlatformDxe => XenAcpiPlatformDxe}/PciDecoding.c | 2 +- > OvmfPkg/{AcpiPlatformDxe => XenAcpiPlatformDxe}/Qemu.c | 3 +-- > OvmfPkg/{AcpiPlatformDxe => XenAcpiPlatformDxe}/QemuFwCfgAcpi.c | 2 +- > OvmfPkg/{AcpiPlatformDxe => XenAcpiPlatformDxe}/Xen.c | 1 + > 12 files changed, 18 insertions(+), 14 deletions(-) Reviewed-by: Philippe Mathieu-Daude