public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Rebecca Cran" <rebecca@nuviainc.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
	Leif Lindholm <leif@nuviainc.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>
Subject: Re: [PATCH 1/1] ArmPkg: Move cache defs used in Universal/Smbios into ArmLib.h
Date: Thu, 10 Jun 2021 16:44:38 -0600	[thread overview]
Message-ID: <bc8e129b-ce0f-1574-646d-0be8b994571d@nuviainc.com> (raw)
In-Reply-To: <CAMj1kXHmHmZYHo9wNRoWrAC3-s5rbYvN1gE2zesJQRWvz+DfOg@mail.gmail.com>

On 6/10/21 9:04 AM, Ard Biesheuvel wrote:
> On Tue, 8 Jun 2021 at 15:54, Rebecca Cran <rebecca@nuviainc.com> wrote:
>> Many of the cache definitions in ArmLibPrivate.h are being used outside
>> of ArmLib, in Universal/Smbios. Move them into ArmLib.h to make them
>> public, and remove the include of ArmLibPrivate.h from files in
>> Universal/Smbios.
>>
>> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
> Hi Rebecca,
>
> If these definitions describe anything more than the software
> interface exposed by the library, they really belong under
> IndustryStandard/ not Library.


It looks like I'd need to create a new file under 
ArmPkg/Include/IndustryStandard since the existing files don't look 
appropriate. I was wondering if a filename like ArmCache.h would be good?


-- 

Rebecca Cran


  reply	other threads:[~2021-06-10 22:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-08 13:54 [PATCH 1/1] ArmPkg: Move cache defs used in Universal/Smbios into ArmLib.h Rebecca Cran
2021-06-10 15:04 ` Ard Biesheuvel
2021-06-10 22:44   ` Rebecca Cran [this message]
2021-06-14 11:28     ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc8e129b-ce0f-1574-646d-0be8b994571d@nuviainc.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox