From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mx.groups.io with SMTP id smtpd.web10.1040.1623365081931022763 for ; Thu, 10 Jun 2021 15:44:42 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=PWshdryB; spf=pass (domain: nuviainc.com, ip: 209.85.214.182, mailfrom: rebecca@nuviainc.com) Received: by mail-pl1-f182.google.com with SMTP id v13so1816879ple.9 for ; Thu, 10 Jun 2021 15:44:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=1BZKdDM9jyRmgwqtoOQfHs5v8kOVFKw5N5nkN1RjP94=; b=PWshdryBucRC9WT6FcBZsl2fg5eHBjWrp5SHdJhkKIREnKA6s8cNfWW7wF0UAx4qQn 5vC0SpgwGlYtYc/6dFUaOZ3iUHooaRGPpPj43bD0Eo6EAAtsAm/1+nWoKjkiSno+o1Hi HZcxZGG47BWaDad0lJ2JHvx9g69zQC8ZUvnWE4eTAkdtOTgS+pUv6eTFuoUJP7uzwCU+ 5GeVB6HsPCm3RDrhFxz3OKu1pdlyNmxHc0vaMF5Z1w/8pHTJEK59jhcX8s5Ltkn/2N4/ ll7lrElYRDHzvcVJVW7IOZmATHTYJuNgqq7pLRKox/Zk1inLEEgPjSMTm/HUDoGoM3RC W3Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=1BZKdDM9jyRmgwqtoOQfHs5v8kOVFKw5N5nkN1RjP94=; b=TiSgYjN0Z2jZHb+CHhUJ37UBOwhZWiOj3jGLGf7d6u6IGVLVgzYAbq1F3df+YUd3qB c8JB8veMPorPolkCE4agBAcnyRU29HaQ+EaVlQ4tXUZtgPRRxeXxhwt64jmckkEtfaTj baYlIsI/X0nW4l9hbUoM5pJcrU948qG1nsBlzy5IPX+Bd46n7L2/tkaVLKWMQLNd8t1q FqmISvLP4PMFuMp8PPIc3cU+TKS5TL0ux+v64nxvx6h6elJgF3U4ZUprLkp+tsRZ4GsY iHnTgXqI7aev2NLBs6drkO9LF5jIuYbLDQuDzMXZnQB9RyZg0koKhMaG9RKpQncpXlx9 rQSQ== X-Gm-Message-State: AOAM531CwjiydtsNPjS+wMROQkSu7YdgWGz2uozV6uUjz08UfJkZ8bee QBcdESQgScfgU1471cMoMlPAIA== X-Google-Smtp-Source: ABdhPJwuGrH2YXonZRYsYthsgVS0RV+d9K9s0gmNjgEWNfuZsUAJBHgWe79N2WulLPkw7JFUP9m6Ng== X-Received: by 2002:a17:90a:e298:: with SMTP id d24mr1162208pjz.36.1623365081477; Thu, 10 Jun 2021 15:44:41 -0700 (PDT) Return-Path: Received: from linbox.int.bluestop.org (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id y205sm3297891pfb.53.2021.06.10.15.44.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Jun 2021 15:44:40 -0700 (PDT) Subject: Re: [PATCH 1/1] ArmPkg: Move cache defs used in Universal/Smbios into ArmLib.h To: Ard Biesheuvel Cc: edk2-devel-groups-io , Leif Lindholm , Ard Biesheuvel References: <20210608135432.23420-1-rebecca@nuviainc.com> From: "Rebecca Cran" Message-ID: Date: Thu, 10 Jun 2021 16:44:38 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 6/10/21 9:04 AM, Ard Biesheuvel wrote: > On Tue, 8 Jun 2021 at 15:54, Rebecca Cran wrote: >> Many of the cache definitions in ArmLibPrivate.h are being used outside >> of ArmLib, in Universal/Smbios. Move them into ArmLib.h to make them >> public, and remove the include of ArmLibPrivate.h from files in >> Universal/Smbios. >> >> Signed-off-by: Rebecca Cran > Hi Rebecca, > > If these definitions describe anything more than the software > interface exposed by the library, they really belong under > IndustryStandard/ not Library. It looks like I'd need to create a new file under ArmPkg/Include/IndustryStandard since the existing files don't look appropriate. I was wondering if a filename like ArmCache.h would be good? -- Rebecca Cran