Re: [edk2-devel] [edk2 Patch 1/1] EmbeddedPkg: Fix compiler errors due to implicit conversions

["Leif Lindholm" <quic_llindhol@quicinc.com>]

On 2024-02-07 19:59, Laszlo Ersek wrote:
> On 2/6/24 17:23, Jayaprakash N wrote:
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4669
>>
>> This commit fixes compilation issues reported through BZ4669.
>> There were several compilation errors due to implicit type
>> conversions in EmbeddedPkg. Fixed all the issues with the
>> correct usage of explicit type conversions based on the
>> context.
>>
>> Cc: Rebecca Cran <rebecca@bsdio.com>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Abner Chang <abner.chang@amd.com>
>> Cc: Jayaprakash N <n.jayaprakash@intel.com>
>> Signed-off-by: Jayaprakash N <n.jayaprakash@intel.com>
>> ---
>>   EmbeddedPkg/GdbStub/X64/Processor.c           | 36 +++++++++----------
>>   EmbeddedPkg/Include/libfdt_env.h              |  8 ++---
>>   EmbeddedPkg/Library/FdtLib/fdt.c              |  9 ++---
>>   EmbeddedPkg/Library/FdtLib/fdt_overlay.c      | 20 +++++------
>>   EmbeddedPkg/Library/FdtLib/fdt_ro.c           | 32 ++++++++---------
>>   EmbeddedPkg/Library/FdtLib/fdt_rw.c           | 24 ++++++-------
>>   EmbeddedPkg/Library/FdtLib/fdt_strerror.c     |  2 +-
>>   EmbeddedPkg/Library/FdtLib/fdt_strtoul.c      |  2 +-
>>   EmbeddedPkg/Library/FdtLib/fdt_sw.c           | 10 +++---
>>   EmbeddedPkg/Library/FdtLib/fdt_wip.c          |  4 +--
>>   .../MemoryAllocationLib.c                     |  2 +-
>>   EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c     |  8 ++---
>>   .../Universal/MmcDxe/MmcIdentification.c      | 22 ++++++------
>>   13 files changed, 90 insertions(+), 89 deletions(-)
> 
> This patch does way too many things at once. Please, minimally, split it
> into multiple patches, at module boundaries.
> 
> Second, I'm unsure if edk2 considers FdtLib a completely detached fork
> of libfdt, at this point. If so, then fixing the warnings in the edk2
> tree is valid (but should still be likely structured with finer
> granularity). If not (i.e., if we still intend to update FdtLib to more
> recent libfdt versions in the future), then these fixes don't belong in
> edk2 (we'd have to redo them after every update); they should be
> upstreamed to libfdt.

The EmbeddedPkg FdtLib is superseded by the MdePkg BaseFdtLib.
My intent is to drop it, but I didn't get around to doing the rework
of existing users in time for the soft freeze.

/
     Leif




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115271): https://edk2.groups.io/g/devel/message/115271
Mute This Topic: https://groups.io/mt/104200931/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-